Skip to content

lmstudio: 0.3.11 -> 0.3.14-3#386864

Merged
FliegendeWurst merged 1 commit intoNixOS:masterfrom
deftdawg:lms
Mar 27, 2025
Merged

lmstudio: 0.3.11 -> 0.3.14-3#386864
FliegendeWurst merged 1 commit intoNixOS:masterfrom
deftdawg:lms

Conversation

@deftdawg
Copy link
Contributor

@deftdawg deftdawg commented Mar 3, 2025

Things done

  • Make lms command line tool available
  • Rename lmstudio executable to lm-studio to match online documentation and appImage executable
    • If you ask DeepSeek or ChatGPT how to use lm-studio, it will tell you the command is lm-studio, so renamed to match that
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin (BROKEN UPSTREAM since lm-studio 0.3.6)
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Ping maintainers @cig0 @eeedean @crertel

@deftdawg deftdawg mentioned this pull request Mar 3, 2025
13 tasks
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 3, 2025
@nix-owners nix-owners bot requested review from cig0, crertel and eeedean March 3, 2025 23:18
@crertel
Copy link
Contributor

crertel commented Mar 4, 2025

I'm a little iffy on the rename of lm-studio, 'cause it might break stuff for some folks, but I'm not strongly against it.

@crertel
Copy link
Contributor

crertel commented Mar 4, 2025

(testing out pr now)

@deftdawg
Copy link
Contributor Author

deftdawg commented Mar 4, 2025

I'm a little iffy on the rename of lm-studio, 'cause it might break stuff for some folks, but I'm not strongly against it.

I'm not sure why it was renamed from the source, maybe to match the package name?

ls /nix/store/*lm*extracted/lm-studio
/nix/store/8bpzvmlm54r83v8ynqihrn69w7v0d80m-lmstudio-0.3.11-extracted/lm-studio
/nix/store/f9l455zqngp7qwqhpfz2fzvbz0jwdhkz-lmstudio-0.3.6-extracted/lm-studio
/nix/store/gknfnzhkfv4slbjkqd7qcf05fn1hfsgq-lmstudio-0.3.10-extracted/lm-studio

@crertel
Copy link
Contributor

crertel commented Mar 4, 2025

So, the good news is that executable runs. The bad news seems to be it won't start.

image

Does it work on your machine?

@deftdawg
Copy link
Contributor Author

deftdawg commented Mar 4, 2025

The app has to be open for lms to connect to it
image

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Mar 5, 2025
@crertel
Copy link
Contributor

crertel commented Mar 8, 2025

@deftdawg Mind bumping to 0.3.12, while you got the hood up? (hashes for both Linux and Mac too if possible).

@deftdawg deftdawg changed the title lmstudio: make lms command line tool available, rename executable lm-studio lmstudio: 0.3.11 -> 0.3.12, make lms command line tool available, rename executable lm-studio Mar 8, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Mar 8, 2025
Copy link
Contributor

@crertel crertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think maybe a typo snuck in to the mac hash?

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 8, 2025
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 9, 2025
@crertel
Copy link
Contributor

crertel commented Mar 13, 2025

@deftdawg we got scooped again...they're at 0.3.13 now, lol.

Mac (via nix-prefetch-url "https://installers.lmstudio.ai/darwin/arm64/0.3.13-1/LM-Studio-0.3.13-1-arm64.dmg" | xargs nix hash to-sri --type sha256):

sha256-fPrTbu/qN0SxLhX9ACd1/T3HLFxQDJ7czHg7QTATaLs=

Linux (via nix-prefetch-url "https://installers.lmstudio.ai/linux/x64/0.3.13-1/LM-Studio-0.3.13-1-x64.AppImage" | xargs nix hash to-sri --type sha256):

sha256-OSNxe2KFj9stnM5x11exMlFDiy+gOa31HRyxzwHtwAk=

@deftdawg
Copy link
Contributor Author

It's a bit frustrating we can't get merges on this package done in a timely manner... Do we need all the maintainers to review before it can merge?

@deftdawg deftdawg changed the title lmstudio: 0.3.11 -> 0.3.12, make lms command line tool available, rename executable lm-studio lmstudio: 0.3.11 -> 0.3.13, make lms command line tool available, rename executable lm-studio Mar 13, 2025
@crertel
Copy link
Contributor

crertel commented Mar 13, 2025

Agreed. I think there's a way of setting up an auto-update script that could help with this; I'll let you know what I find out.

@deftdawg
Copy link
Contributor Author

Oh, okay no worries, I didn't know ofBorg worked off of commit messages like that. All good, I'll redo it that way in a couple hours when I'm back home. 🍻

@deftdawg deftdawg changed the title lmstudio: 0.3.11 -> 0.3.13, make lms command line tool available, rename executable lm-studio lmstudio: 0.3.11 -> 0.3.13 Mar 16, 2025
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 16, 2025
@wolfgangwalther wolfgangwalther dismissed their stale review March 17, 2025 21:54

commit message fixed

@crertel
Copy link
Contributor

crertel commented Mar 23, 2025

@jopejoe1 not to be a bother, but since you helped out last time, could you help us merge? (if not, that's fine!)

@deftdawg
Copy link
Contributor Author

Evening @crertel! Just saw a beta for 0.3.14 pop-up on LM Studio's site so came over here to see if this is still pending review...

Was thinking if this doesn't merge before 0.3.14, my next push might just drop @cig0 and @eeedean from the maintainers list at the same time it bumps versions, so future merges can happen quicker.

@FliegendeWurst
Copy link
Member

FliegendeWurst commented Mar 23, 2025

The easiest solution for fast updates is adding an updateScript, so r-ryantm will automatically update. Then you can merge the update with the merge bot, if you are listed in meta.maintainers.
Of course it would also be good if meta.maintainers contains only active maintainers.

@deftdawg deftdawg changed the title lmstudio: 0.3.11 -> 0.3.13 lmstudio: 0.3.11 -> 0.3.14-3 Mar 25, 2025
@deftdawg deftdawg requested a review from FliegendeWurst March 25, 2025 04:46
@deftdawg
Copy link
Contributor Author

Thanks @FliegendeWurst, I applied your changes and then re-squashed the PR.

@FliegendeWurst
Copy link
Member

CI check for formatting failed, please run nixfmt 'pkgs/by-name/lm/lmstudio/package.nix' with nixpkgs' nixfmt

@deftdawg
Copy link
Contributor Author

deftdawg commented Mar 26, 2025

CI check for formatting failed, please run nixfmt 'pkgs/by-name/lm/lmstudio/package.nix' with nixpkgs' nixfmt

I used nix-shell to get nixfmt, then ran it on both files and re-squash committed and force pushed it, but nixfmt step still failed 😢

@FliegendeWurst
Copy link
Member

You did nix-shell (no arguments) in the nixpkgs root, right? (or used the nixfmt-rfc-style package?)

@deftdawg
Copy link
Contributor Author

You did nix-shell (no arguments) in the nixpkgs root, right? (or used the nixfmt-rfc-style package?)

I did nix-shell -p nixfmt, then ran nixfmt on each of the two files... It definitely reformatted them (changes are visible here: https://github.com/NixOS/nixpkgs/compare/e94b24304eb27b342a499a2abcf46c6211cbe29f..e564476c52dc13602ce46df1347a7f8997b4953b)

Was I supposed to use nixfmt-rfc-style instead of nixfmt?

@FliegendeWurst
Copy link
Member

Yes. It is a bit confusing that the regular nixfmt is not the right version for use in nixpkgs.

You can do either

  • nix-shell (no arguments!) in nixpkgs repository root
  • nix-shell -p nixfmt-rfc-style

To get the right one.

@deftdawg
Copy link
Contributor Author

Reformatted with nix-shell -p nixfmt-rfc-style, should be ready to go now 🤞

@FliegendeWurst FliegendeWurst merged commit 15e8110 into NixOS:master Mar 27, 2025
24 of 27 checks passed
@crertel
Copy link
Contributor

crertel commented Mar 27, 2025

Thanks for your help @FliegendeWurst ! Congrats @deftdawg !

@deftdawg deftdawg deleted the lms branch March 27, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants