lmstudio: 0.3.11 -> 0.3.14-3#386864
Conversation
|
I'm a little iffy on the rename of |
|
(testing out pr now) |
I'm not sure why it was renamed from the source, maybe to match the package name? |
|
@deftdawg Mind bumping to |
crertel
left a comment
There was a problem hiding this comment.
LGTM, but I think maybe a typo snuck in to the mac hash?
|
@deftdawg we got scooped again...they're at 0.3.13 now, lol. Mac (via
Linux (via
|
|
It's a bit frustrating we can't get merges on this package done in a timely manner... Do we need all the maintainers to review before it can merge? |
|
Agreed. I think there's a way of setting up an auto-update script that could help with this; I'll let you know what I find out. |
|
Oh, okay no worries, I didn't know ofBorg worked off of commit messages like that. All good, I'll redo it that way in a couple hours when I'm back home. 🍻 |
|
@jopejoe1 not to be a bother, but since you helped out last time, could you help us merge? (if not, that's fine!) |
|
Evening @crertel! Just saw a beta for 0.3.14 pop-up on LM Studio's site so came over here to see if this is still pending review... Was thinking if this doesn't merge before 0.3.14, my next push might just drop @cig0 and @eeedean from the maintainers list at the same time it bumps versions, so future merges can happen quicker. |
|
The easiest solution for fast updates is adding an |
|
Thanks @FliegendeWurst, I applied your changes and then re-squashed the PR. |
|
CI check for formatting failed, please run |
I used nix-shell to get nixfmt, then ran it on both files and re-squash committed and force pushed it, but nixfmt step still failed 😢 |
|
You did |
I did Was I supposed to use |
|
Yes. It is a bit confusing that the regular nixfmt is not the right version for use in nixpkgs. You can do either
To get the right one. |
|
Reformatted with |
|
Thanks for your help @FliegendeWurst ! Congrats @deftdawg ! |


Things done
lm-studio, so renamed to match thatnix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.
Ping maintainers @cig0 @eeedean @crertel