Conversation
|
Reviewed this using A couple of minor things I noticed, not specific to this PR:
|
|
Turns out it's slightly more complicated, need to # lms cli tool
install -m 755 ${appimageContents}/resources/app/.webpack/lms $out/bin/
${final.patchelf}/bin/patchelf --set-interpreter "${final.stdenv.cc.bintools.dynamicLinker}" \
--set-rpath "${final.stdenv.cc.cc.lib}/lib:${final.stdenv.cc.cc.lib}/lib64:$out/lib:${final.lib.makeLibraryPath [final.stdenv.cc.cc.lib]}" $out/bin/lmsHere's the full overlay: (final: prev: {
lmstudio = let
version = "0.3.10";
rev = "6";
pname = "lmstudio";
src = final.fetchurl {
url = "https://installers.lmstudio.ai/linux/x64/${version}-${rev}/LM-Studio-${version}-${rev}-x64.AppImage";
hash = "sha256-sAGU20gaDaFo5jvuCcN4tkVTlqvuXVCqvrHyl3yg384=";
};
appimageContents = final.appimageTools.extractType2 { inherit pname version src; };
in final.appimageTools.wrapType2 {
inherit pname version src;
extraPkgs = pkgs: with pkgs; [
ocl-icd
];
extraInstallCommands = ''
mkdir -p $out/share/applications
cp -r ${appimageContents}/usr/share/icons $out/share
install -m 444 ${appimageContents}/lm-studio.desktop $out/share/applications/
substituteInPlace $out/share/applications/lm-studio.desktop \
--replace 'Exec=AppRun --no-sandbox %U' 'Exec=lmstudio'
# lms cli tool
install -m 755 ${appimageContents}/resources/app/.webpack/lms $out/bin/
${final.patchelf}/bin/patchelf --set-interpreter "${final.stdenv.cc.bintools.dynamicLinker}" \
--set-rpath "${final.stdenv.cc.cc.lib}/lib:${final.stdenv.cc.cc.lib}/lib64:$out/lib:${final.lib.makeLibraryPath [final.stdenv.cc.cc.lib]}" $out/bin/lms
'';
};
})@cig0 can you approve/merge the PR? Then I can try adding lms to another PR (or you can roll it in to this). |
|
@deftdawg that's freakin' awesome, great work! I think it should go in its own PR once this one is merged. |
f7dafd6 to
84d0e5b
Compare
|
Updated to match the upstream change to overridable urls and hashes. |
deftdawg
left a comment
There was a problem hiding this comment.
I used this PR on X86_64 and it's good to go.
|
0.3.11 is out now... it kinda sucks we can't get enough reviewers to merge promptly |
|
@deftdawg ...sigh, lemme update again. |
|
sha256-T8j0l2ZP53Zc0hgb2EyFeR0mH5YrNlz4UfzN0rO7bKU= |
|
macOS-Issue persists unfortunately. So no change on darwin side of things. |
|
Yep, this PR marks it as broken for Mac, I've pinged LM Studio many times on that issue asking if they'll fix it, they said they would but then went silent. Anyway need to get this merged... @crertel, not sure what you committed but it doesn't show it having bumped the version to 0.3.11 here (don't forget to edit the issue title too) |
|
@deftdawg should be good now, I think. |
|
@deftdawg I think that tees you up for your PR about pulling |
Update to 0.3.11.
This also marks lmstudio as broken on mac.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.