opencv: use c++ 17 to fix protobuf support#386339
opencv: use c++ 17 to fix protobuf support#386339ZeroEcks wants to merge 2 commits intoNixOS:masterfrom
Conversation
fb428a4 to
fbced4e
Compare
|
Tests pass on linux, same issue as on OfBorg on darwin. It seems unrelated to my changes however, I think the tests are just broken on darwin. |
|
Has that similar implications as abseilcpp that we need multiple versions with multiple c++ versions? |
|
As an alternative I would take a look at #375774 |
|
@SuperSando2000 can you clarify the implications in abseilcpp or link the issue for me? |
That other PR downgrades protobuf as used by opencv in the second commit (623bb414eed06f91e85792189c800453f8c34557), is that the best solution here? |
|
@ZeroEcks Please rebase, do not use merging in nixpkgs. The merge commit needs to be dropped in this case. |
|
changes have been implemented in the other PR, I think this is not needed anymore :) |
At some point protobuf was disabled due to not using C++ 17. This commit enables it just like what they had to do over in brew.. This fixes #386327
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.