Skip to content

Comments

opencv: use c++ 17 to fix protobuf support#386339

Closed
ZeroEcks wants to merge 2 commits intoNixOS:masterfrom
ZeroEcks:opencv-fix-protobuf
Closed

opencv: use c++ 17 to fix protobuf support#386339
ZeroEcks wants to merge 2 commits intoNixOS:masterfrom
ZeroEcks:opencv-fix-protobuf

Conversation

@ZeroEcks
Copy link

@ZeroEcks ZeroEcks commented Mar 2, 2025

At some point protobuf was disabled due to not using C++ 17. This commit enables it just like what they had to do over in brew.. This fixes #386327

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ZeroEcks ZeroEcks force-pushed the opencv-fix-protobuf branch from fb428a4 to fbced4e Compare March 2, 2025 09:59
@NixOSInfra NixOSInfra added the 12.first-time contribution This PR is the author's first one; please be gentle! label Mar 2, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Mar 2, 2025
@nix-owners nix-owners bot requested a review from basvandijk March 2, 2025 10:06
@ZeroEcks
Copy link
Author

ZeroEcks commented Mar 4, 2025

Tests pass on linux, same issue as on OfBorg on darwin. It seems unrelated to my changes however, I think the tests are just broken on darwin.

@autra autra mentioned this pull request Mar 7, 2025
13 tasks
@SuperSandro2000
Copy link
Member

Has that similar implications as abseilcpp that we need multiple versions with multiple c++ versions?

@SuperSandro2000
Copy link
Member

As an alternative I would take a look at #375774

@ZeroEcks
Copy link
Author

@SuperSando2000 can you clarify the implications in abseilcpp or link the issue for me?

@eclairevoyant
Copy link
Contributor

eclairevoyant commented Apr 21, 2025

As an alternative I would take a look at #375774

That other PR downgrades protobuf as used by opencv in the second commit (623bb414eed06f91e85792189c800453f8c34557), is that the best solution here?

@eclairevoyant
Copy link
Contributor

@ZeroEcks Please rebase, do not use merging in nixpkgs. The merge commit needs to be dropped in this case.

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 28, 2025
@ZeroEcks
Copy link
Author

changes have been implemented in the other PR, I think this is not needed anymore :)

@ZeroEcks ZeroEcks closed this Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

opencv/digikam: OpenCV modification to protobuf has disabled protobuf and broken facial recognition in digikam

5 participants