Skip to content

Comments

opencv: use C++17#163045

Merged
BrewTestBot merged 2 commits intoHomebrew:masterfrom
ZhongRuoyu:opencv-c++17
Feb 17, 2024
Merged

opencv: use C++17#163045
BrewTestBot merged 2 commits intoHomebrew:masterfrom
ZhongRuoyu:opencv-c++17

Conversation

@ZhongRuoyu
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

C++17 is necessary for OpenCV to use Protobuf, due to: https://github.com/opencv/opencv/blob/4.9.0/cmake/OpenCVFindProtobuf.cmake#L81-L88

Fixes https://github.com/orgs/Homebrew/discussions/5138.

@github-actions github-actions bot added python Python use is a significant feature of the PR or issue ffmpeg FFMPEG use is a significant feature of the PR or issue labels Feb 17, 2024
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would test also need a change?

system ENV.cxx, "-std=c++11", "test.cpp", "-I#{include}/opencv4", "-o", "test"

@github-actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Feb 17, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Feb 17, 2024
Merged via the queue into Homebrew:master with commit bf3760c Feb 17, 2024
@ZhongRuoyu ZhongRuoyu deleted the opencv-c++17 branch February 17, 2024 14:40
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 18, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. ffmpeg FFMPEG use is a significant feature of the PR or issue outdated PR was locked due to age python Python use is a significant feature of the PR or issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants