Skip to content

Comments

kikit: 1.7.0 -> 1.7.1, use newer pyproject = true#385032

Merged
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
jfly:update-kikit-use-pyproject
Feb 26, 2025
Merged

kikit: 1.7.0 -> 1.7.1, use newer pyproject = true#385032
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
jfly:update-kikit-use-pyproject

Conversation

@jfly
Copy link
Contributor

@jfly jfly commented Feb 25, 2025

Changelog: https://github.com/yaqwsx/KiKit/releases/tag/v1.7.1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

As a side effect, this fixes an incorrect hash that presumably came from
upstream force pushing a git tag.
@jfly jfly mentioned this pull request Feb 25, 2025
@jfly jfly force-pushed the update-kikit-use-pyproject branch from ddd35ad to 3954f00 Compare February 25, 2025 14:53
@jfly jfly requested a review from SuperSandro2000 February 25, 2025 14:54
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 25, 2025
@nix-owners nix-owners bot requested a review from matusf February 25, 2025 14:56
@jfly
Copy link
Contributor Author

jfly commented Feb 25, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 385032


x86_64-linux

✅ 4 packages built:
  • kicadAddons.kikit
  • kicadAddons.kikit-library
  • kikit
  • kikit.dist

@jcdickinson
Copy link
Contributor

Testing with my kicad9 branch shows that openscad is needed in nativeCheckInputs. I'm not sure if that's going to impact this PR.

@jcdickinson jcdickinson mentioned this pull request Feb 25, 2025
8 tasks
@jfly
Copy link
Contributor Author

jfly commented Feb 25, 2025

Testing with my kicad9 branch shows that openscad is needed in nativeCheckInputs. I'm not sure if that's going to impact this PR.

Hmm... why am I not seeing that in this branch when I try to build kikit?

@jcdickinson
Copy link
Contributor

Testing with my kicad9 branch shows that openscad is needed in nativeCheckInputs. I'm not sure if that's going to impact this PR.

Hmm... why am I not seeing that in this branch when I try to build kikit?

It must be a kicad 9 thing in that case, I'll poke around once this gets merged.

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Feb 26, 2025
@jfly jfly force-pushed the update-kikit-use-pyproject branch from 3954f00 to f726d31 Compare February 26, 2025 18:42
@jfly jfly requested a review from SuperSandro2000 February 26, 2025 18:42
@SuperSandro2000 SuperSandro2000 merged commit e0decf2 into NixOS:master Feb 26, 2025
25 of 27 checks passed
@jfly jfly deleted the update-kikit-use-pyproject branch February 26, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants