kicad: 8.0.8 -> 9.0.0 by jcdickinson · Pull Request #384150 · NixOS/nixpkgs

jcdickinson · 2025-02-22T04:40:14Z

Release announcement: https://www.kicad.org/blog/2025/02/Version-9.0.0-Released/

Beyond updating the refs/shas, I needed to add protobuf and nng as dependencies. I also switched it to Ninja, as that is recommended by the KiCad docs (https://dev-docs.kicad.org/en/build/linux/index.html#_ninja).

Things done

Built on platform(s)
- x86_64-linux
- aarch64-linux
- x86_64-darwin
- aarch64-darwin
For non-Linux: n/a - tested on NixOS unstable
Tested, as applicable: N/A, not a lib or a function
Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". (processing)
Tested basic functionality of all binary files (usually in ./result/bin/)
Smoke test of project binaries (from kicad, kicad-testing, and kicad-unstable), including first setup and libraries
25.05 Release Notes: these have been reverted in the past when I added them, let me know if I should make them.
Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

pkgs/applications/science/electronics/kicad/base.nix

xokdvium · 2025-02-22T05:40:41Z

pkgs/applications/science/electronics/kicad/base.nix

Ninja hook will ignore this now. You'd have to switch to ninjaFlags.

I Googled and grepped around here and came up empty-handed: not sure how to pass these flags through to a CMAKE-generated ninja build as flags. I have moved these to a preconfigure sh export.

Yup, this makes sense. Sorry for setting you off on a wild goose chase.
It might also be possible to use CMAKE_{C,CXX}_FLAGS for this. I hope there wasn't some very specific reason why this was previously done by passing CFLAGS as make parameter.

debug flags are as expected (snippet from the build log):

/nix/store/ii75mhh7sxl11167m1b86p0qrjsjyjmd-gcc-wrapper-14-20241116/bin/g++ -DDEBUG ..... -DKICAD_STDLIB_DEBUG ..... -I...... -Og -ggdb ...... -o libs/kimath/CMakeFiles/kimath.dir/src/md5_hash.cpp.o -c /build/source/libs/kimath/src/md5_hash.cpp

I wouldn't be able to augment C_FLAGS and CXX_FLAGS if I used the {C,CXX}_FLAGS shorthand. I could just clobber them entirely (they are empty at the start of configure anyway).

pkgs/applications/science/electronics/kicad/base.nix

xokdvium

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 384150

`x86_64-linux`

❌ 4 packages failed to build:

kicadAddons.kikit
kicadAddons.kikit-library
kikit
kikit.dist

✅ 12 packages built:

kicad
kicad-small
kicad-testing
kicad-testing-small
kicad-unstable
kicad-unstable-small
python312Packages.kicad
python312Packages.pcbnewtransition
python312Packages.pcbnewtransition.dist
python313Packages.kicad
python313Packages.pcbnewtransition
python313Packages.pcbnewtransition.dist

error: builder for '/nix/store/hbc0p5i0vmx1qg7fyxlaz8bmchz4aq72-kikit-1.6.0.drv' failed with exit code 2;
       last 25 log lines:
       > # 12:16:23: Error: Directory '/homeless-shelter' couldn't be created (error 13: Permission denied)
       > # 12:16:23: Error: Directory '/homeless-shelter/.config/kicad/9.0' couldn't be created (error 2: No such file or directory)
       > # An error occurred: No board edges found
       > # No output files produced
       > not ok 42 Steel stencils with cutout

kikit might need a writableTmpDirAsHomeHook hook as well as some other changes.
Looks like #383480 is necessary for KiCad 9.0 support: https://github.com/yaqwsx/KiKit/releases/tag/v1.7.0

diff --git a/pkgs/by-name/ki/kikit/default.nix b/pkgs/by-name/ki/kikit/default.nix
index 69e7c4eef099..7db181e7204b 100644
--- a/pkgs/by-name/ki/kikit/default.nix
+++ b/pkgs/by-name/ki/kikit/default.nix
@@ -19,6 +19,7 @@
   pybars3,
   versioneer,
   shapely,
+  writableTmpDirAsHomeHook,
 }:
 let
   solidpython = callPackage ./solidpython { };
@@ -64,6 +65,7 @@ buildPythonApplication rec {
   nativeCheckInputs = [
     pytestCheckHook
     bats
+    writableTmpDirAsHomeHook
   ];
 
   pythonImportsCheck = [

korken89

I've tested it building on aarch64-linux now, no issues and runs as expected.

jcdickinson · 2025-02-25T01:09:44Z

writableTmpDirAsHomeHook

That fixed the build, though now the tests are failing. Seems like we will have to wait for the linked PR.

jfly · 2025-02-25T12:13:39Z

Seems like we will have to wait for the linked PR.

@jcdickinson, #383480 is now merged.

jcdickinson · 2025-02-25T20:19:58Z

Waiting for #385032.

openscad needs to be added to nativeCheckInputs (in kikit), I'm not sure if that will need to be done to get 385032 merged too.

jcdickinson · 2025-02-27T00:21:26Z

openscad needs to be added to nativeCheckInputs (in kikit), I'm not sure if that will need to be done to get 385032 merged too.

I must have messed up the manual patching, this is not happening now that I've rebased on the real merge. The home dir hook seemingly isn't required either.

xokdvium

kicad, kicad-small, kicad-unstable launch fine and there are no obvious issues.

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 384150

`x86_64-linux`

✅ 16 packages built:

kicad
kicad-small
kicad-testing
kicad-testing-small
kicad-unstable
kicad-unstable-small
kicadAddons.kikit
kicadAddons.kikit-library
kikit
kikit.dist
python312Packages.kicad
python312Packages.pcbnewtransition
python312Packages.pcbnewtransition.dist
python313Packages.kicad
python313Packages.pcbnewtransition
python313Packages.pcbnewtransition.dist

changelog: https://github.com/yaqwsx/KiKit/releases/tag/v1.7.2 This brings in support for KiCAD v9: https://github.com/yaqwsx/KiKit/releases/tag/v1.7.2, as [we upgraded to KiCAD v9 recently](#384150).

github-actions bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Feb 22, 2025

nix-owners bot requested a review from evils February 22, 2025 04:48

xokdvium suggested changes Feb 22, 2025

View reviewed changes

SuperSandro2000 reviewed Feb 22, 2025

View reviewed changes

pkgs/applications/science/electronics/kicad/base.nix Outdated Show resolved Hide resolved

jcdickinson force-pushed the kicad-9 branch from df6c19a to b6ce272 Compare February 23, 2025 02:50

jcdickinson requested review from SuperSandro2000 and xokdvium February 23, 2025 02:51

xokdvium reviewed Feb 23, 2025

View reviewed changes

korken89 reviewed Feb 24, 2025

View reviewed changes

jcdickinson force-pushed the kicad-9 branch from b6ce272 to 50c24c7 Compare February 25, 2025 01:08

nix-owners bot requested review from jfly and matusf February 25, 2025 01:16

jfly approved these changes Feb 25, 2025

View reviewed changes

jfly mentioned this pull request Feb 25, 2025

kikit: 1.6.0 -> 1.7.0 #383480

Merged

wegank added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Feb 25, 2025

jcdickinson force-pushed the kicad-9 branch from 6d3c4b5 to 54e3a0f Compare February 25, 2025 20:18

wegank removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 26, 2025

jcdickinson force-pushed the kicad-9 branch from 54e3a0f to d533ffa Compare February 27, 2025 00:17

kicad: 8.0.8 -> 9.0.0

c60228a

jcdickinson force-pushed the kicad-9 branch from d533ffa to c60228a Compare February 27, 2025 00:21

jcdickinson requested review from jfly, korken89 and xokdvium February 27, 2025 00:21

jfly approved these changes Feb 27, 2025

View reviewed changes

xokdvium approved these changes Feb 27, 2025

View reviewed changes

matusf approved these changes Feb 27, 2025

View reviewed changes

SuperSandro2000 merged commit f60f9db into NixOS:master Feb 27, 2025
27 checks passed

jfly mentioned this pull request Apr 1, 2025

kikit: 1.7.1 -> 1.7.2, python3.pkgs.pcbnewtransition: 0.5.0 -> 0.5.2: Fix kikit build #395213

Merged

13 tasks

wolfgangwalther mentioned this pull request Apr 5, 2025

Update request: kicad-unstable b7b64d959f → current #327181

Closed

1 task

Uh oh!

Comments

Conversation

jcdickinson commented Feb 22, 2025

Things done

Uh oh!

Uh oh!

Uh oh!

xokdvium Feb 22, 2025

Choose a reason for hiding this comment

Uh oh!

jcdickinson Feb 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xokdvium Feb 23, 2025

Choose a reason for hiding this comment

Uh oh!

jcdickinson Feb 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

xokdvium left a comment

Choose a reason for hiding this comment

nixpkgs-review result

x86_64-linux

Uh oh!

korken89 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jcdickinson commented Feb 25, 2025

Uh oh!

jfly commented Feb 25, 2025

Uh oh!

jcdickinson commented Feb 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jcdickinson commented Feb 27, 2025

Uh oh!

xokdvium left a comment

Choose a reason for hiding this comment

nixpkgs-review result

x86_64-linux

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

jcdickinson Feb 23, 2025 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`

korken89 left a comment •

edited

Loading

jcdickinson commented Feb 25, 2025 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`