rocmPackages_6: bump to 6.3.1 and add more packages#384159
Closed
GZGavinZhao wants to merge 28 commits intoNixOS:masterfrom
Closed
rocmPackages_6: bump to 6.3.1 and add more packages#384159GZGavinZhao wants to merge 28 commits intoNixOS:masterfrom
GZGavinZhao wants to merge 28 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
6.topic: python
ofborg
bot
added
the
2.status: merge conflict
Member
|
Can you fix the eval issue in the CI and merge conflict? |
GZGavinZhao
force-pushed
the
gzgz-rocm-update
branch
from
b783b5b to
9c80c8d
Compare
ofborg
bot
removed
the
2.status: merge conflict
Signed-off-by: Gavin Zhao <git@gzgz.dev>
Signed-off-by: Gavin Zhao <git@gzgz.dev>
Signed-off-by: Gavin Zhao <git@gzgz.dev>
Signed-off-by: Gavin Zhao <git@gzgz.dev>
Signed-off-by: Gavin Zhao <git@gzgz.dev>
Signed-off-by: Gavin Zhao <git@gzgz.dev>
Signed-off-by: Gavin Zhao <git@gzgz.dev>
Signed-off-by: Gavin Zhao <git@gzgz.dev>
…e_mha_operations `device_mha_operations` are not built in composable_kernel if the requested GPU targets is not one of `gfx90a`, `gfx94*`, or `gfx95*` according to [this line](https://github.com/ROCm/composable_kernel/blob/6b6fcd370bb2e5572422a1ca71d261df02b6263e/library/src/tensor_operation_instance/gpu/CMakeLists.txt#L371), but MIOpen always wants `device_mha_operations`. To remedy this, just always add `gfx90a` to `gpuTargets`. Signed-off-by: Gavin Zhao <git@gzgz.dev>
Signed-off-by: Gavin Zhao <git@gzgz.dev>
Signed-off-by: Gavin Zhao <git@gzgz.dev>
Signed-off-by: Gavin Zhao <git@gzgz.dev>
Signed-off-by: Gavin Zhao <git@gzgz.dev>
GZGavinZhao
force-pushed
the
gzgz-rocm-update
branch
from
9c80c8d to
3ba40b0
Compare
…X_BUILD_CORES Signed-off-by: Gavin Zhao <git@gzgz.dev>
Signed-off-by: Gavin Zhao <git@gzgz.dev>
Contributor
|
Note that 6.3.3 was released a few days ago; version 6.3.2 seems to have fixed an issue w.r.t. hipsparse: |
Signed-off-by: Gavin Zhao <git@gzgz.dev>
Signed-off-by: Gavin Zhao <git@gzgz.dev>
Signed-off-by: Gavin Zhao <git@gzgz.dev>
Signed-off-by: Gavin Zhao <git@gzgz.dev>
GZGavinZhao
force-pushed
the
gzgz-rocm-update
branch
from
df1641c to
4449f63
Compare
Contributor
|
@GZGavinZhao why has this be closed? |
Member
because it was obsoleted by #367695 which has been merged |
Contributor
Author
Contributor
|
Indeed, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: if this line is still here, this means this PR may not build yet
Supercedes #367695.
Reworked ROCm LLVM based on #370435. As of 2025-02-22, I don't think the LLVM infrastructure in nixpkgs is mature enough to use it in ROCm (e.g. the difficulty with overriding specific components). Currently, using standalone HIP compiler makes building
rocmPackages_6easier and allows us to use different compilers for C++ and HIP separately. We do want to reuse code inpkgs/development/compilers/llvmin the future though, just not now.I belive I've hammered out the details of the standalone HIP compiler and I just need to verify it works for all the packages. I'm rebuilding the packages using the standalone HIP compiler one-by-one, making relevant changes to make CMake recognize the HIP compiler and cleaning up existing code on my way.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.