ROCm 6: Refactor ROCm LLVM to standalone HIP compiler#370435
Closed
GZGavinZhao wants to merge 1 commit intoNixOS:masterfrom
Closed
ROCm 6: Refactor ROCm LLVM to standalone HIP compiler#370435GZGavinZhao wants to merge 1 commit intoNixOS:masterfrom
GZGavinZhao wants to merge 1 commit intoNixOS:masterfrom
Conversation
Signed-off-by: Gavin Zhao <git@gzgz.dev>
github-actions
bot
added
the
6.topic: rocm
13 tasks
13 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demonstration of a possible fix for #368672. Will work on commit messages later if we decide we want to merge this.
Currently, we build our own LLVM derivation because (as far as I have checked) it builds essentially out-of-the-box and runs fine.
I'm also aware of the existing code to build
llvmPackages_*and I'm trying to reuse them.Currently, this PR is planned to be merged after #367695 due to the large number of changes already planned in that PR.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.