Skip to content

follow: 0.2.0-beta.2 -> 0.3.7 #383051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pbsds merged 1 commit into from
Mar 20, 2025
Merged

follow: 0.2.0-beta.2 -> 0.3.7 #383051

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions pkgs/by-name/fo/follow/package.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@
stdenv.mkDerivation rec {
pname = "follow";

version = "0.2.0-beta.2";
version = "0.3.7";

src = fetchFromGitHub {
owner = "RSSNext";
repo = "Follow";
rev = "v${version}";
hash = "sha256-7KSPZj9QG6zksji/eY8jczBDHr/9tStlw26LKVqXTAw=";
hash = "sha256-TPzrQo6214fXQmF45p5agQ1zqLYzpmMpYb89ASPsWio=";
};

nativeBuildInputs = [
Expand All @@ -30,19 +30,18 @@ stdenv.mkDerivation rec {

pnpmDeps = pnpm_9.fetchDeps {
inherit pname version src;
hash = "sha256-FzMjN0rIjYxexf6tix4qi3mnuPkadjKihhN0Pj5y2nU=";
hash = "sha256-xNGLYzEz1G5sZSqmji+ItJ9D1vvZcwkkygnDeuypcIM=";
};

env = {
ELECTRON_SKIP_BINARY_DOWNLOAD = "1";

# This environment variables inject the production Vite config at build time.
# Copy from:
# 1. https://github.com/RSSNext/Follow/blob/v0.2.0-beta.2/.github/workflows/build.yml#L18
# 1. https://github.com/RSSNext/Follow/blob/v0.3.7/.github/workflows/build.yml#L18
# 2. And logs in the corresponding GitHub Actions: https://github.com/RSSNext/Follow/actions/workflows/build.yml
VITE_WEB_URL = "https://app.follow.is";
VITE_API_URL = "https://api.follow.is";
VITE_IMGPROXY_URL = "https://thumbor.follow.is";
VITE_SENTRY_DSN = "https://e5bccf7428aa4e881ed5cb713fdff181@o4507542488023040.ingest.us.sentry.io/4507570439979008";
VITE_OPENPANEL_CLIENT_ID = "0e477ab4-d92d-4d6e-b889-b09d86ab908e";
VITE_OPENPANEL_API_URL = "https://openpanel.follow.is/api";
Expand All @@ -57,6 +56,8 @@ stdenv.mkDerivation rec {
};
};

dontCheckForBrokenSymlinks = true;
Copy link
Contributor

@gepbird gepbird Mar 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this works around it and the package builds, but it would be better to understand why does symlinks were broken, if its an upstream issue we sheuld report it. I'll check it soon if you're busy.

This can be done in a follow up PR, I don't want to delay this package update which also aims to make the package work again.

The broken symlink error was caused by subprojects having a link to the main .env file, which should be created from .env.example at a development stage, for production we already have the env variables, so we can delete the subprojects' .env symlink.

I think the packaging could be improved overall, currently the whole source directory is copied to out, and all the generated node_modules, which is overall 1.9G. Can we build an asar out of it, wrap it with electron and only ship that, has anybody attempted it before?

Copy link
Contributor Author

@iosmanthus iosmanthus Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could arrange that.

Yes this works around it and the package builds, but it would be better to understand why does symlinks were broken, if its an upstream issue we sheuld report it. I'll check it soon if you're busy.

This can be done in a follow up PR, I don't want to delay this package update which also aims to make the package work again.

The broken symlink error was caused by subprojects having a link to the main .env file, which should be created from .env.example at a development stage, for production we already have the env variables, so we can delete the subprojects' .env symlink.

I think the packaging could be improved overall, currently the whole source directory is copied to out, and all the generated node_modules, which is overall 1.9G. Can we build an asar out of it, wrap it with electron and only ship that, has anybody attempted it before?


desktopItem = makeDesktopItem {
name = "follow";
desktopName = "Follow";
Expand Down