Conversation
github-actions
bot
added
10.rebuild-darwin: 0
wegank
added
the
12.approvals: 1
gepbird
left a comment
gepbird
left a comment
There was a problem hiding this comment.
This package is broken on master and here too since #370750:
follow> ERROR: noBrokenSymlinks: the symlink /nix/store/zgsb0b39p2j7g5ic2bsvp73awm5gaqjz-follow-0.3.5/share/follow/apps/mobile/.env points to a missing target /nix/store/zgsb0b39p2j7g5ic2bsvp73awm5gaqjz-follow-0.3.5/share/follow/.env
follow> ERROR: noBrokenSymlinks: the symlink /nix/store/zgsb0b39p2j7g5ic2bsvp73awm5gaqjz-follow-0.3.5/share/follow/apps/renderer/.env points to a missing target /nix/store/zgsb0b39p2j7g5ic2bsvp73awm5gaqjz-follow-0.3.5/share/follow/.env
follow> ERROR: noBrokenSymlinks: the symlink /nix/store/zgsb0b39p2j7g5ic2bsvp73awm5gaqjz-follow-0.3.5/share/follow/apps/server/.env points to a missing target /nix/store/zgsb0b39p2j7g5ic2bsvp73awm5gaqjz-follow-0.3.5/share/follow/.env
follow> ERROR: noBrokenSymlinks: found 3 dangling symlinks and 0 reflexive symlinks 
iosmanthus
force-pushed
the
follow-0.3.5
branch
from
350956a to
6eb9f69
Compare
iosmanthus
changed the title
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
iosmanthus
force-pushed
the
follow-0.3.5
branch
from
6eb9f69 to
434c4f7
Compare
|
@gepbird PTAL |
|
Yes this works around it and the package builds, but it would be better to understand why does symlinks were broken, if its an upstream issue we sheuld report it. I'll check it soon if you're busy. |
wegank
removed
the
12.approvals: 1
gepbird
left a comment
gepbird
left a comment
There was a problem hiding this comment.
GUI launches, should be good to go!
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 383051
x86_64-linux
✅ 1 package built:
- follow
| }; | ||
| }; | ||
|
|
||
| dontCheckForBrokenSymlinks = true; |
There was a problem hiding this comment.
Yes this works around it and the package builds, but it would be better to understand why does symlinks were broken, if its an upstream issue we sheuld report it. I'll check it soon if you're busy.
This can be done in a follow up PR, I don't want to delay this package update which also aims to make the package work again.
The broken symlink error was caused by subprojects having a link to the main .env file, which should be created from .env.example at a development stage, for production we already have the env variables, so we can delete the subprojects' .env symlink.
I think the packaging could be improved overall, currently the whole source directory is copied to out, and all the generated node_modules, which is overall 1.9G. Can we build an asar out of it, wrap it with electron and only ship that, has anybody attempted it before?
There was a problem hiding this comment.
I could arrange that.
Yes this works around it and the package builds, but it would be better to understand why does symlinks were broken, if its an upstream issue we sheuld report it. I'll check it soon if you're busy.
This can be done in a follow up PR, I don't want to delay this package update which also aims to make the package work again.
The broken symlink error was caused by subprojects having a link to the main .env file, which should be created from .env.example at a development stage, for production we already have the env variables, so we can delete the subprojects' .env symlink.
I think the packaging could be improved overall, currently the whole source directory is copied to out, and all the generated node_modules, which is overall 1.9G. Can we build an asar out of it, wrap it with electron and only ship that, has anybody attempted it before?
wegank
added
the
12.approvals: 2
4 participants
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.