Skip to content

maintainers: adding hakujin#382460

Closed
hakujin wants to merge 1 commit intoNixOS:masterfrom
hakujin:add-hakujin-maintainer
Closed

maintainers: adding hakujin#382460
hakujin wants to merge 1 commit intoNixOS:masterfrom
hakujin:add-hakujin-maintainer

Conversation

@hakujin
Copy link
Contributor

@hakujin hakujin commented Feb 16, 2025

Adds hakujin (Colin King) to maintainers.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Adds hakujin (Colin King) to maintainers.
@github-actions github-actions bot added 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 16, 2025
@donovanglover
Copy link
Member

We usually don't add maintainers unless they take on maintaining a package. Would you be willing to add yourself as a maintainer for shen-sbcl? Ideally this would be done in #380807 instead of a separate PR

@drupol
Copy link
Contributor

drupol commented Feb 16, 2025

Hello,

Thank you for your request and your interest in Nix!

Could you please provide some context or motivation behind your request to be added to the maintainer list? It would be helpful for us to understand how this aligns with your intentions or contributions to the project.

In my opinion, it might be more effective to create a PR that demonstrates why being included in the maintainer list is relevant. For instance:

  • Are you planning to contribute to nixpkgs?
  • Do you intend to adopt and maintain specific packages?

If your goal is to adopt packages, there's no need for a separate PR for this request. Instead, you can include a commit in a PR where it's clear which packages you'd like to maintain.

Please note that this is not about discouraging new contributors, on the contrary! We value new maintainers, and some contextual information will help us streamline the process and support your contributions effectively.

Thank you.

@hakujin
Copy link
Contributor Author

hakujin commented Feb 16, 2025

Thanks, I mistakenly thought I'd need to add myself first, then tag myself as a maintainer in the shen-sbcl package. Closing this PR in favor of doing both in #380807.

@hakujin hakujin closed this Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants