shen-sbcl: 3.0.3 -> 39.1#380807
Conversation
3571e9c to
5457555
Compare
|
@bsima As the author of the original PR, are you still interested in maintaining this package? I can't request you as a reviewer since you aren't in the NixOS organization. |
5457555 to
660a912
Compare
donovanglover
left a comment
There was a problem hiding this comment.
Please create multiple commits to follow contributing guidelines. Make sure that the maintainer commit comes before adding yourself as a maintainer of the package.
- maintainers: add hakujin
- shen-sbcl: 3.0.3 -> 39.1
- shen-sbcl: add hakujin as maintainer
Adds hakujin (Colin King) to maintainers.
9ce27af to
af832ab
Compare
|
@donovanglover is there anything else that needs to happen here? It looks like there is one stuck ofBorg check that has been queued for about 24 hours. Is this typical? |
|
Pending CI checks are common and not a blocker for merges. Tools like We still have to review other parts of the PR, which can take a while depending on how many people with the adequate knowledge are interested in it. |
af832ab to
952ce0f
Compare
donovanglover
left a comment
There was a problem hiding this comment.
LGTM after changing the commit message to shen-sbcl: 3.0.3 -> 39.1. Also left some nits to align the package with conventions
Migrates to the new "S"-style Shen kernels which brings with them a new build system. Removes the (now deprecated) shen-sources package.
Adds hakujin (Colin King) as a maintainer for `shen-sbcl`.
952ce0f to
8eb3466
Compare
Thanks for the feedback; I believe everything has been addressed and this is ready to go. |
|
Migrates to the new "S"-style Shen kernels which brings with them a new build system. Removes the (now deprecated) shen-sources package.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.