Skip to content

shen-sbcl: 3.0.3 -> 39.1#380807

Merged
donovanglover merged 3 commits intoNixOS:masterfrom
hakujin:hakujin/fix-shen
Mar 13, 2025
Merged

shen-sbcl: 3.0.3 -> 39.1#380807
donovanglover merged 3 commits intoNixOS:masterfrom
hakujin:hakujin/fix-shen

Conversation

@hakujin
Copy link
Contributor

@hakujin hakujin commented Feb 10, 2025

Migrates to the new "S"-style Shen kernels which brings with them a new build system. Removes the (now deprecated) shen-sources package.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@hakujin hakujin changed the title Fix shen-sbcl package shen-sbcl: 3.0.3 -> S39.1 Feb 10, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 10, 2025
@hakujin hakujin changed the title shen-sbcl: 3.0.3 -> S39.1 shen-sbcl: 3.0.3 -> 0-S39.1 Feb 10, 2025
@donovanglover donovanglover mentioned this pull request Feb 16, 2025
13 tasks
@donovanglover
Copy link
Member

@bsima As the author of the original PR, are you still interested in maintaining this package? I can't request you as a reviewer since you aren't in the NixOS organization.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Feb 16, 2025
Copy link
Member

@donovanglover donovanglover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create multiple commits to follow contributing guidelines. Make sure that the maintainer commit comes before adding yourself as a maintainer of the package.

  • maintainers: add hakujin
  • shen-sbcl: 3.0.3 -> 39.1
  • shen-sbcl: add hakujin as maintainer

Adds hakujin (Colin King) to maintainers.
@hakujin hakujin force-pushed the hakujin/fix-shen branch 2 times, most recently from 9ce27af to af832ab Compare February 18, 2025 15:33
@hakujin
Copy link
Contributor Author

hakujin commented Feb 19, 2025

@donovanglover is there anything else that needs to happen here? It looks like there is one stuck ofBorg check that has been queued for about 24 hours. Is this typical?

@donovanglover
Copy link
Member

Pending CI checks are common and not a blocker for merges. Tools like nixpkgs-review-gha are often used to confirm that packages build successfully.

We still have to review other parts of the PR, which can take a while depending on how many people with the adequate knowledge are interested in it.

Copy link
Member

@donovanglover donovanglover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after changing the commit message to shen-sbcl: 3.0.3 -> 39.1. Also left some nits to align the package with conventions

Colin King added 2 commits March 12, 2025 21:57
Migrates to the new "S"-style Shen kernels which brings with them a new
build system. Removes the (now deprecated) shen-sources package.
Adds hakujin (Colin King) as a maintainer for `shen-sbcl`.
@hakujin hakujin changed the title shen-sbcl: 3.0.3 -> 0-S39.1 shen-sbcl: 3.0.3 -> 39.1 Mar 13, 2025
@hakujin
Copy link
Contributor Author

hakujin commented Mar 13, 2025

LGTM after changing the commit message to shen-sbcl: 3.0.3 -> 39.1. Also left some nits to align the package with conventions

Thanks for the feedback; I believe everything has been addressed and this is ready to go.

@donovanglover
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 380807

Logs: https://github.com/donovanglover/nixpkgs-review-gha/actions/runs/13826754550


x86_64-linux

✅ 1 package built:
  • shen-sbcl

aarch64-linux

✅ 1 package built:
  • shen-sbcl

x86_64-darwin

✅ 1 package built:
  • shen-sbcl

aarch64-darwin

✅ 1 package built:
  • shen-sbcl

Copy link
Member

@donovanglover donovanglover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM grats on your first contribution to nixpkgs!

Edit: Actually this isn't your first contribution but welcome to the maintainers list!

@donovanglover donovanglover merged commit edb70a9 into NixOS:master Mar 13, 2025
35 of 37 checks passed
@hakujin hakujin deleted the hakujin/fix-shen branch March 13, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants