Skip to content

[Backport release-24.11] addBinToPathHook and writableTmpDirAsHomeHook hooks#380071

Merged
drupol merged 5 commits intoNixOS:release-24.11from
drupol:push-qqvrypvlzzty
Feb 7, 2025
Merged

[Backport release-24.11] addBinToPathHook and writableTmpDirAsHomeHook hooks#380071
drupol merged 5 commits intoNixOS:release-24.11from
drupol:push-qqvrypvlzzty

Conversation

@drupol
Copy link
Contributor

@drupol drupol commented Feb 7, 2025

Backport of:

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@drupol drupol marked this pull request as ready for review February 7, 2025 12:28
@github-actions github-actions bot added the 8.has: documentation This PR adds or changes documentation label Feb 7, 2025
@drupol drupol mentioned this pull request Feb 7, 2025
13 tasks
@nix-owners nix-owners bot requested a review from Ericson2314 February 7, 2025 12:29
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 7, 2025
@drupol
Copy link
Contributor Author

drupol commented Feb 7, 2025

I'm going to merge this thing as-is now, despite those 2 red statuses on the CI that can be ignored:

  • The "Check cherry-picks" is failing because the file doc/redirects.json doesn't exist on release-24.11.
  • The "Vet nixpkgs" is complaining because the hooks are not in pkgs/by-name

@drupol drupol merged commit 9a195ac into NixOS:release-24.11 Feb 7, 2025
38 of 39 checks passed
@drupol drupol deleted the push-qqvrypvlzzty branch February 7, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant