Merged
Conversation
13 tasks
Member
|
Actually I'd suggest ditching the addEnvHooks shenanigans here entirely, instead put it in postHooks. |
github-actions
bot
added
10.rebuild-darwin: 101-500
Contributor
Author
Do you have an example in mind so I can get some inspiration?
|
Member
|
drupol
force-pushed
the
push-xtnvumnztqsw
branch
2 times, most recently
from
62c1a35 to
0593c8b
Compare
Member
Not |
drupol
force-pushed
the
push-xtnvumnztqsw
branch
from
0593c8b to
b5066be
Compare
Contributor
Author
|
So much things to learn there... thank you for all your information! |
Contributor
Author
|
@jian-lin I just tested |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: #378110 (comment)
The implementation of addEnvHooks may be helpful.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.