Skip to content

tree-sitter: 0.24.6 -> 0.25.1#379367

Merged
ambroisie merged 2 commits intoNixOS:stagingfrom
ambroisie:tree-sitter-0.25.1
Feb 14, 2025
Merged

tree-sitter: 0.24.6 -> 0.25.1#379367
ambroisie merged 2 commits intoNixOS:stagingfrom
ambroisie:tree-sitter-0.25.1

Conversation

@ambroisie
Copy link
Contributor

Things done

Release notes: https://github.com/tree-sitter/tree-sitter/releases/tag/v0.25.1

I couldn't update the grammars, first because of the wrong token environment variable, and then because I still got rate limited on the computer I used to run the update.

I'll say that I expect a lot of churn on the patch file to disable the playground, compared to when it used to just substituteInPlace a few lines.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ambroisie ambroisie mentioned this pull request Feb 4, 2025
13 tasks
@github-actions github-actions bot added 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Feb 4, 2025
Copy link
Member

@amadaluzia amadaluzia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not so much a blocker, if you don't mind though, could you update the grammars?

Cheers :^)

@ambroisie
Copy link
Contributor Author

@amadaluzia as mentioned in the description, I couldn't run the update script for the grammars due to rate limiting on my computer, despite the token.

@amadaluzia
Copy link
Member

Oh, just saw that now.

I'll see if I can update the grammars.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5187

@ambroisie
Copy link
Contributor Author

@amadaluzia friendly ping.

@amadaluzia
Copy link
Member

Hey there! I got caught up externally but I should be able to properly update this now.

@ambroisie
Copy link
Contributor Author

@amadaluzia I'll go ahead and merge this now, you can update the grammars in a different PR.

@ambroisie
Copy link
Contributor Author

@uncenter @Profpatsch friendly ping, I'd really like a review, rather than blindly self-merging into staging which feels "impolite".

Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM

@ambroisie ambroisie merged commit b457952 into NixOS:staging Feb 14, 2025
24 checks passed
@amadaluzia amadaluzia mentioned this pull request Feb 14, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants