Skip to content

tree-sitter: 0.24.6 -> 0.24.7#376729

Closed
amadaluzia wants to merge 0 commit intoNixOS:stagingfrom
amadaluzia:update-tree-sitter-nu
Closed

tree-sitter: 0.24.6 -> 0.24.7#376729
amadaluzia wants to merge 0 commit intoNixOS:stagingfrom
amadaluzia:update-tree-sitter-nu

Conversation

@amadaluzia
Copy link
Member

What has changed?

https://github.com/tree-sitter/tree-sitter/releases/tag/v0.24.7

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@uncenter
Copy link
Member

uncenter commented Jan 25, 2025

This commit does a lot more than just updating it. The formatting should be done in a separate commit or PR to make this diff more readable.

And fwiw #375546 already exists, I guess the difference here is that all the grammars are updated.

@amadaluzia
Copy link
Member Author

This commit does a lot more than just updating it. The formatting should be done in a separate commit or PR to make this diff more readable.

I noticed this, I'm pretty sure this was a cause of my editor autoformatting by default. I'll fix that.

@amadaluzia amadaluzia force-pushed the update-tree-sitter-nu branch 2 times, most recently from 80b0c78 to e6512f7 Compare January 27, 2025 02:22
@github-actions github-actions bot added 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Jan 27, 2025
@nix-owners nix-owners bot requested review from Profpatsch and uncenter January 27, 2025 02:31
@FliegendeWurst FliegendeWurst changed the base branch from master to staging January 27, 2025 15:41
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 27, 2025
@amadaluzia amadaluzia force-pushed the update-tree-sitter-nu branch from e6512f7 to 06ecab5 Compare January 27, 2025 18:37
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 27, 2025
@amadaluzia amadaluzia force-pushed the update-tree-sitter-nu branch from 696de0a to 3a70bea Compare January 28, 2025 14:35
@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: games Gaming on NixOS 6.topic: dotnet Language: .NET labels Jan 28, 2025
@amadaluzia
Copy link
Member Author

amadaluzia commented Jan 28, 2025

my mistake, the master to staging thing fucked the workflow outstandingly bad

sorry for the mass ping over nothing, i promise to hone my git-fu in post

@Bullish-Design
Copy link

Hate to be a pain, but is there any chance to bump the treesitter version to 25.0?

https://github.com/tree-sitter/tree-sitter/releases/tag/v0.25.0

@amadaluzia
Copy link
Member Author

I'll be frank, it's worth another PR since this one's history is fucked

@amadaluzia amadaluzia deleted the update-tree-sitter-nu branch February 3, 2025 18:37
@ambroisie
Copy link
Contributor

@Bullish-Design see #379367.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: dotnet Language: .NET 6.topic: games Gaming on NixOS 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants