Skip to content

electron_32: fix log spam when building on aarch64-linux #378988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emilylange merged 1 commit into from
Feb 3, 2025
Merged

electron_32: fix log spam when building on aarch64-linux #378988

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions pkgs/development/tools/electron/common.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,20 @@ in
''
+ base.postPatch;

env =
base.env
// lib.optionalAttrs (lib.versionOlder info.version "33" && stdenv.hostPlatform.isAarch64) {
# Hydra fails to build electron_32.aarch64-linux as of 2025-01-05 due to
# clang spamming deprecation warnings mid-build, causing the build log to
# grow beyond the limit of 64mb and then getting killed by Hydra. This
# renders our clang both too old for the latest chromium without the use
# of -Wno-unknown-warning-option and also too new for electron_32 (M128).
# For some reason, this is exclusively happening on aarch64-linux. To
# unbreak the build on h.n.o, we simply disable those warnings for now.
# https://hydra.nixos.org/build/283952243
NIX_CFLAGS_COMPILE = base.env.NIX_CFLAGS_COMPILE + " -Wno-deprecated";
};

preConfigure =
''
(
Expand Down