electron_32: fix log spam when building on aarch64-linux#378988
Merged
emilylange merged 1 commit intoNixOS:masterfrom Feb 3, 2025
Merged
electron_32: fix log spam when building on aarch64-linux#378988emilylange merged 1 commit intoNixOS:masterfrom
emilylange merged 1 commit intoNixOS:masterfrom
Conversation
clang-19 deprecation warnings on aarch64-linux specifically are causing the log grow beyond h.n.o's log limit of 64mb, which in turn causes the build to get killed. To work around this, likely until electron_32 is EOL in a month, we simply disable those deprecation warnings. We still have another things causing unnecessary logs, but this should be good enough for now. https://hydra.nixos.org/build/283952243
Member
Author
|
Builds on We still get roughtly ~35k times since #323869, but I haven't had time to fix that yet. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clang-19 deprecation warnings on aarch64-linux specifically are causing the log grow beyond h.n.o's log limit of 64mb, which in turn causes the build to get killed.
To work around this, likely until electron_32 is EOL in a month, we simply disable those deprecation warnings. We still have another things causing unnecessary logs, but this should be good enough for now.
https://hydra.nixos.org/build/283952243
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)