Skip to content

electron_32: fix log spam when building on aarch64-linux#378988

Merged
emilylange merged 1 commit intoNixOS:masterfrom
emilylange:electron_32
Feb 3, 2025
Merged

electron_32: fix log spam when building on aarch64-linux#378988
emilylange merged 1 commit intoNixOS:masterfrom
emilylange:electron_32

Conversation

@emilylange
Copy link
Member

clang-19 deprecation warnings on aarch64-linux specifically are causing the log grow beyond h.n.o's log limit of 64mb, which in turn causes the build to get killed.

To work around this, likely until electron_32 is EOL in a month, we simply disable those deprecation warnings. We still have another things causing unnecessary logs, but this should be good enough for now.

https://hydra.nixos.org/build/283952243

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

clang-19 deprecation warnings on aarch64-linux specifically are causing
the log grow beyond h.n.o's log limit of 64mb, which in turn causes the
build to get killed.

To work around this, likely until electron_32 is EOL in a month, we
simply disable those deprecation warnings. We still have another things
causing unnecessary logs, but this should be good enough for now.

https://hydra.nixos.org/build/283952243
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 3, 2025
@nix-owners nix-owners bot requested review from teutat3s and yayayayaka February 3, 2025 01:20
@emilylange
Copy link
Member Author

Builds on aarch64-linux and the log file is around 13 MiB (uncompressed) at the end.

We still get

Warning: supplying the --target argument to a nix-wrapped compiler may not work correctly - cc-wrapper is currently not designed with multi-target compilers in mind. You may want to use an un-wrapped compiler instead.

roughtly ~35k times since #323869, but I haven't had time to fix that yet.
But at least with 13 MiB < 64 MB (sic!), the build should no longer get killed on h.n.o 🫠

@emilylange emilylange merged commit e522ddb into NixOS:master Feb 3, 2025
25 of 27 checks passed
@emilylange emilylange deleted the electron_32 branch February 3, 2025 12:47
TomaSajt pushed a commit that referenced this pull request Mar 24, 2025
As a precaution and to avoid problems with hydra builds that had to
be fixed in the past. References: ce04dc5 (#378988) and 3f514d3.
nixpkgs-ci bot pushed a commit that referenced this pull request Mar 24, 2025
As a precaution and to avoid problems with hydra builds that had to
be fixed in the past. References: ce04dc5 (#378988) and 3f514d3.

(cherry picked from commit 506d38b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments