Skip to content

xsv: remove#377107

Merged
fpletz merged 1 commit intoNixOS:masterfrom
alyssais:xsv-remove
Jan 29, 2025
Merged

xsv: remove#377107
fpletz merged 1 commit intoNixOS:masterfrom
alyssais:xsv-remove

Conversation

@alyssais
Copy link
Member

4 years since the last upstream commit. Lockfile is too old for fetchCargoVendor.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

4 years since the last upstream commit.  Lockfile is too old for
fetchCargoVendor.
@alyssais alyssais requested review from emilazy and jgertm January 26, 2025 20:25
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 26, 2025
@ddogfoodd
Copy link
Contributor

thanks to @NotAShelf we will soon get xan (https://github.com/medialab/xan) which is a maintained fork of xsv

See: #375564

@eljamm eljamm added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jan 26, 2025
@fpletz fpletz merged commit d933c63 into NixOS:master Jan 29, 2025
27 of 29 checks passed
@teto
Copy link
Member

teto commented Jan 30, 2025

I had just started using xsv :'( would be nice to recommand a replacement in the alias. xan is a fork of xsv , seems like there is a pending PR #375564

@teto teto mentioned this pull request Jan 30, 2025
13 tasks
@alyssais alyssais deleted the xsv-remove branch January 30, 2025 09:24
@rsynnest
Copy link
Contributor

@teto qsv is a maintained fork available in nixpkgs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants