Skip to content

xan: init at 0.42.0#375564

Merged
teto merged 1 commit intoNixOS:masterfrom
NotAShelf:xan-init
Feb 1, 2025
Merged

xan: init at 0.42.0#375564
teto merged 1 commit intoNixOS:masterfrom
NotAShelf:xan-init

Conversation

@NotAShelf
Copy link
Member

@NotAShelf NotAShelf commented Jan 21, 2025

Adds Xan, the CSV magician.

It's a very powerful tool to work with CSV files, which I'm not surprised is
packaged already. This PR adds the derivation. Tested locally, only built on
Linux. Darwin testing appreciated.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See
    Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using
    nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all
    changes have to be committed, also see
    nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in
    ./result/bin/)
  • 25.05 Release Notes
    (or backporting
    24.11
    and
    25.05
    Release notes)
    • (Package updates) Added a release notes entry if the change is major or
      breaking
    • (Module updates) Added a release notes entry if the change is
      significant
    • (Module addition) Added a release notes entry if adding a new NixOS
      module
  • Fits
    CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 21, 2025
@NotAShelf NotAShelf marked this pull request as draft January 21, 2025 16:03
@emilazy
Copy link
Member

emilazy commented Jan 21, 2025

Copying what I said on Matrix: They have cut stable releases, but only on crates.io; see https://crates.io/crates/xan/versions. We should either fetch it from crates.io or identify the Git revision that corresponds to 0.41.0 and bump to that. (Ideally of course we convince upstream to start cutting Git tags.)

@NotAShelf NotAShelf changed the title xan: init at 0.13.0 xan: init at 0.41.0 Jan 21, 2025
@NotAShelf
Copy link
Member Author

I've updated the package to use fetchCrate until upstream makes a move.

@NotAShelf NotAShelf marked this pull request as ready for review January 21, 2025 19:36
@ddogfoodd
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 375564


x86_64-linux

✅ 1 package built:
  • xan

@ddogfoodd
Copy link
Contributor

Thank you @NotAShelf !

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 22, 2025
@ddogfoodd
Copy link
Contributor

Likely, we can switch to fetching from GitHub with the next version as upstream just said they would use tags from 0.42.0 on

@ddogfoodd
Copy link
Contributor

Or would it be better to just init at 0.42.0 since this PR is not merged yet?

@NotAShelf
Copy link
Member Author

I'll be changing the version to 0.42.0 shortly, as soon as I unpack my computer.

@NotAShelf NotAShelf marked this pull request as draft January 24, 2025 16:41
@NotAShelf NotAShelf changed the title xan: init at 0.41.0 xan: init at 0.42.0 Jan 24, 2025
@NotAShelf NotAShelf marked this pull request as ready for review January 24, 2025 17:53
@ddogfoodd
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 375564


x86_64-linux

✅ 1 package built:
  • xan

Copy link
Contributor

@ddogfoodd ddogfoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

builds and works fine on x86_64-linux, thanks again @NotAShelf !

@ddogfoodd ddogfoodd mentioned this pull request Jan 26, 2025
13 tasks
Copy link
Contributor

@eljamm eljamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 375564


x86_64-linux

✅ 1 package built:
  • xan

aarch64-linux

✅ 1 package built:
  • xan

x86_64-darwin

✅ 1 package built:
  • xan

aarch64-darwin

✅ 1 package built:
  • xan

Copy link
Contributor

@eljamm eljamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@eljamm eljamm added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jan 29, 2025
Copy link
Member

@chvp chvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 375564


aarch64-darwin

✅ 1 package built:
  • xan

Also tested functionality a bit, worked without issues.

@teto
Copy link
Member

teto commented Jan 30, 2025

Maybe you could mention xan in the alias throw here #377107 (comment)

@NotAShelf
Copy link
Member Author

Good idea, I'll change the throw later today.

@NotAShelf
Copy link
Member Author

I've updated the xsv alias to mention xan.

@teto
Copy link
Member

teto commented Feb 1, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 375564


x86_64-linux

✅ 1 package built:
  • xan

@teto teto merged commit cfb5cd1 into NixOS:master Feb 1, 2025
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants