treewide: correct versionCheckHook use#376275
Conversation
pbsds
force-pushed
the
fix-versionCheckHooks-1737677407
branch
from
dfb8723 to
e170449
Compare
github-actions
bot
added
10.rebuild-darwin: 11-100
|
1 similar comment
|
|
Be careful with python packages: #375320 (comment) |
philiptaron
left a comment
philiptaron
left a comment
There was a problem hiding this comment.
Suggestion on the HOME-desiring ones
There was a problem hiding this comment.
So this one is not converted over, correct?
There was a problem hiding this comment.
correct, it is no longer a silent no-op, but also it doesn't work due to requiring HOMe
pkgs/by-name/go/gollama/package.nix
Outdated
There was a problem hiding this comment.
Do these work if you add this?
preInstallCheckPhase = ''
export HOME=$(mktemp -d)
'';There was a problem hiding this comment.
Not due to env --ignore-environment
There was a problem hiding this comment.
Ah, the -i flag went into the noise but --ignore-environment really says what it does.
wegank
added
the
12.approvals: 1
pbsds
force-pushed
the
fix-versionCheckHooks-1737677407
branch
from
e170449 to
d71e753
Compare
|
I looked into whether i could set HOME in versionCheckHook or testers.testVersion, but neither allow for adding environ variables. |
|
5 participants
Lots of packages don't put
versionCheckHookinnativeInstallCheckInputs, or forget to enable the phase.Candidates where located using
rg versionCheckHook -l | xargs grep doInstallCheck -L | xargs grep buildPythonApplication -LThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.