python312Packages.manim: 0.18.1 -> 0.19.0#375320
Merged
GaetanLepage merged 1 commit intoNixOS:masterfrom Jan 21, 2025
Merged
Conversation
github-actions
bot
added
the
6.topic: python
github-actions
bot
added
10.rebuild-darwin: 0
Contributor
Author
|
python 3.13 failures are caused by a broken dependency and are unrelated. |
GaetanLepage
requested review from
FliegendeWurst,
SuperSandro2000 and
natsukium
NickCao
reviewed
Jan 21, 2025
| pytest-cov-stub | ||
| pytest-xdist | ||
| pytestCheckHook | ||
| versionCheckHook |
Member
There was a problem hiding this comment.
versionCheckHook should be in nativeInstallCheckInputs, and doInstallCheck should be set.
Contributor
Author
There was a problem hiding this comment.
Usually yes, but not for python packages (unless I'm wrong).
I was never able to get the installCheckPhase running on them. I don't remember well, but I think that there is a reason.
Member
There was a problem hiding this comment.
For Python checkPhase is mapped to the installCheckPhase 🤷♂️
Contributor
Author
|
NickCao
approved these changes
Jan 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
Changelog: https://docs.manim.community/en/latest/changelog/0.19.0-changelog.html
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.