bazel, bazel_7: move to pkgs/by-name/ba/#375056
Conversation
|
big merge conflicts, probably needs to be re-done. |
4fea212 to
c948c21
Compare
|
Rebased, conflicts were not very bazel-specific |
|
bazel_5 and 6 are no more and othe merge conflicts. |
f7a0334 to
a53442f
Compare
|
Rebased now 👍 |
|
I don't think we should remove the tests |
|
Removed files were only used by bazel 5&6 but not by bazel 7. |
|
I think removal is fine, same reasoning as per #362199, but I wonder why the tests are being neglected. edit: more merge conflicts |
|
I think for bazel_7 there was enough to do to just make it build compared to 5&6, and making tests work was substantial amount of work that wasn't yet done, also possibly it could have different set of tests than 5&6 had. |
a53442f to
036ae34
Compare
|
rebased to fix conflicts |
|
|
||
| # Bazel | ||
| /pkgs/development/tools/build-managers/bazel @Profpatsch | ||
| /pkgs/by-name/ba/bazel_7 @Profpatsch |
There was a problem hiding this comment.
You can add yourself too @boltzmannrain as I see you support Bazel a lot in Nixpkgs. CC also @layus
|
|
||
| bazel_7 = callPackage ../development/tools/build-managers/bazel/bazel_7 { | ||
| bazel_7 = callPackage ../by-name/ba/bazel_7/package.nix { | ||
| inherit (darwin) sigtool; |
There was a problem hiding this comment.
This can also be moved in this PR if you also change the package.nix code to bring these into it. bazel_self in particular is finalAttrs.finalPackage. But I will merge this without it.
Mostly a pure move keeping pkgs/top-level darwin overrides.
Shared files from
pkgs/development/tools/build-managers/bazel/are copied to eachbazel_{version]that uses them instead of figuring out the way to keep sharing. Patch sharing is of limited value, tests sharing looks more reasonable butbazel_7(or upcomingbazel_8) doesn't use those tests and a new test setup would need to be implemented anyway.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.