Merged
Conversation
There are some unused patch files and files related to tests that aren't used, were likely copied from `bazel_6` but weren't make to work. It is quite possible that https://github.com/bazelbuild/examples won't be a good fit to test recent bazel versions so better cleanup non-working code and remain open for any working way to add tests. The deleted stuff still remains in git history and in bazel 6 and below packages for reference if needed.
boltzmannrain
force-pushed
the
bazel_7_cleanup
branch
from
9c586d2 to
e34631a
Compare
github-actions
bot
added
10.rebuild-darwin: 0
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some unused patch files and files related to tests that aren't used, were likely copied from
bazel_6but weren't make to work.It is quite possible that https://github.com/bazelbuild/examples won't be a good fit to test recent bazel versions so better cleanup non-working code and remain open for any working way to add tests. The deleted stuff still remains in git history and in bazel 6 and below packages for reference if needed.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.