Skip to content

lldap: pin wasm-bindgen-cli to 0.2.95#374179

Merged
bendlas merged 1 commit intoNixOS:masterfrom
mjm:push-mpttlsztsvwn
Jan 19, 2025
Merged

lldap: pin wasm-bindgen-cli to 0.2.95#374179
bendlas merged 1 commit intoNixOS:masterfrom
mjm:push-mpttlsztsvwn

Conversation

@mjm
Copy link
Contributor

@mjm mjm commented Jan 16, 2025

wasm-bindgen-cli was updated in #361490, but it seems like lldap fails to build if the version doesn't exactly match the one it's using from Cargo. This pins it back to the version it was using before.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 16, 2025
@nix-owners nix-owners bot requested a review from bendlas January 16, 2025 00:44
Copy link
Contributor

@ibizaman ibizaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Tested with nix-build -A pkgs.lldap

@bendlas
Copy link
Contributor

bendlas commented Jan 19, 2025

Thank you very much!

@bendlas bendlas merged commit f624d9c into NixOS:master Jan 19, 2025
23 of 25 checks passed
@rcambrj
Copy link
Contributor

rcambrj commented Jan 22, 2025

Howdy folks. Any ideas why I might now be getting this error?

error: builder for '/nix/store/rgyrwlq7gdp5b9dg9hlxcf0b8g0mzdvp-lldap-frontend-0.6.1.drv' failed with exit code 1;
       last 10 log lines:
       >    Compiling yew-router v0.16.0
       >    Compiling lldap_app v0.6.1 (/build/source/app)
       >     Finished `release` profile [optimized] target(s) in 9m 08s
       > [INFO]: Installing wasm-bindgen...
       > error: could not find `wasm-bindgen-cli` in registry `crates-io` with version `=0.2.95`
       > Error: Installing wasm-bindgen with cargo
       > Caused by: Installing wasm-bindgen with cargo
       > Caused by: failed to execute `cargo install`: exited with exit status: 101
       >   full command: "cargo" "install" "--force" "wasm-bindgen-cli" "--root" "/build/source/.cache/.wasm-pack/.wasm-bindgen-cargo-install-0.2.95" "--version" "0.2.95"
       > gzip: pkg/lldap_app_bg.wasm: No such file or directory

0.2.95 hasn't been yanked... although 0.2.94 has for some reason.

@mjm
Copy link
Contributor Author

mjm commented Jan 22, 2025

What revision of nixpkgs are you on? That error is the exact problem that this PR was solving, and it should be in all of the unstable branches now.

@rcambrj
Copy link
Contributor

rcambrj commented Jan 22, 2025

I'm sorry, you're absolutely right. I messed up and thought I was on a revision after this fix 😞 thanks for your fast response!

@mjm mjm deleted the push-mpttlsztsvwn branch February 14, 2025 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants