lldap: pin wasm-bindgen-cli to 0.2.95#374179
Merged
bendlas merged 1 commit intoNixOS:masterfrom Jan 19, 2025
Merged
Conversation
alapshin
approved these changes
Jan 18, 2025
ibizaman
approved these changes
Jan 19, 2025
Contributor
ibizaman
left a comment
There was a problem hiding this comment.
👍 Tested with nix-build -A pkgs.lldap
Contributor
|
Thank you very much! |
13 tasks
Contributor
|
Howdy folks. Any ideas why I might now be getting this error? 0.2.95 hasn't been yanked... although 0.2.94 has for some reason. |
Contributor
Author
|
What revision of nixpkgs are you on? That error is the exact problem that this PR was solving, and it should be in all of the unstable branches now. |
Contributor
|
I'm sorry, you're absolutely right. I messed up and thought I was on a revision after this fix 😞 thanks for your fast response! |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wasm-bindgen-cli was updated in #361490, but it seems like lldap fails to build if the version doesn't exactly match the one it's using from Cargo. This pins it back to the version it was using before.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.