Skip to content

lldap-cli: 0-unstable-2024-02-24 -> 0-unstable-2024-11-11#374905

Merged
FliegendeWurst merged 1 commit intoNixOS:masterfrom
ibizaman:lldap-cli
Jan 28, 2025
Merged

lldap-cli: 0-unstable-2024-02-24 -> 0-unstable-2024-11-11#374905
FliegendeWurst merged 1 commit intoNixOS:masterfrom
ibizaman:lldap-cli

Conversation

@ibizaman
Copy link
Contributor

@ibizaman ibizaman commented Jan 18, 2025

Quick smoke check:

$ nix-build -A pkgs.lldap-cli
this derivation will be built:
  /nix/store/zy0ixjrflb94kvsbrkl97817pj9y3d46-lldap-cli-0-unstable-2024-11-11.drv
building '/nix/store/zy0ixjrflb94kvsbrkl97817pj9y3d46-lldap-cli-0-unstable-2024-11-11.drv'...
Running phase: unpackPhase
unpacking source archive /nix/store/lq9y7rmkp0x1g51jr1hs10wbhc78i0qw-source
source root is source
Running phase: patchPhase
Running phase: updateAutotoolsGnuConfigScriptsPhase
Running phase: installPhase
Running phase: fixupPhase
shrinking RPATHs of ELF executables and libraries in /nix/store/m69yq15chb53pcajbvdz1z4j5jjnagql-lldap-cli-0-unstable-2024-11-11
checking for references to /build/ in /nix/store/m69yq15chb53pcajbvdz1z4j5jjnagql-lldap-cli-0-unstable-2024-11-11...
patching script interpreter paths in /nix/store/m69yq15chb53pcajbvdz1z4j5jjnagql-lldap-cli-0-unstable-2024-11-11
/nix/store/m69yq15chb53pcajbvdz1z4j5jjnagql-lldap-cli-0-unstable-2024-11-11/bin/.lldap-cli-wrapped: interpreter directive changed from "#!/usr/bin/env bash" to "/nix/store/5mh7kaj2fyv8mk4sfq1brwxgc02884wi-bash-5.2p37/bin/bash"
stripping (with command strip and flags -S -p) in  /nix/store/m69yq15chb53pcajbvdz1z4j5jjnagql-lldap-cli-0-unstable-2024-11-11/bin
/nix/store/m69yq15chb53pcajbvdz1z4j5jjnagql-lldap-cli-0-unstable-2024-11-11

$ ./result/bin/lldap-cli --help
LLDAP-CLI(1)

NAME
  lldap-cli - 'lldap' Administration & Configuration CLI

...

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ibizaman ibizaman requested a review from nwhirschfeld January 18, 2025 23:33
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 18, 2025
@ibizaman ibizaman force-pushed the lldap-cli branch 4 times, most recently from deb4349 to ce1f5bb Compare January 19, 2025 11:18
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Jan 19, 2025
@nix-owners nix-owners bot requested a review from bendlas January 19, 2025 11:26
@bendlas
Copy link
Contributor

bendlas commented Jan 19, 2025

AFAICT nixfmt complains about literally a single whitespace:

± nix-shell -p nixfmt-rfc-style --run "nixfmt pkgs/by-name/ll/lldap-cli/package.nix" && git diff
diff --git a/pkgs/by-name/ll/lldap-cli/package.nix b/pkgs/by-name/ll/lldap-cli/package.nix
index 689e9cb2d9a0..71872a916407 100644
--- a/pkgs/by-name/ll/lldap-cli/package.nix
+++ b/pkgs/by-name/ll/lldap-cli/package.nix
@@ -50,7 +50,7 @@ stdenv.mkDerivation {
           gnugrep
           gnused
           jq
-          lldap  # Needed for lldap_set_password
+          lldap # Needed for lldap_set_password
           curl
         ]
       }

Copy link
Contributor

@bendlas bendlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoke test works, thanks!

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jan 21, 2025
@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jan 22, 2025
@FliegendeWurst FliegendeWurst merged commit 76ce79f into NixOS:master Jan 28, 2025
28 of 30 checks passed
@ibizaman ibizaman deleted the lldap-cli branch January 29, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants