Skip to content

pcl: misc cleanups #373913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GaetanLepage merged 3 commits into from
May 18, 2025
Merged

pcl: misc cleanups #373913

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
04ae6a5
pcl: fix CUDA support
al3xtjames May 14, 2025
e9911fe
pcl: build with `PCL_ENABLE_MARCHNATIVE=false`
al3xtjames May 14, 2025
3c92534
pcl: limit libopenmp dependency to Clang
al3xtjames May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions pkgs/by-name/pc/pcl/package.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ stdenv.mkDerivation (finalAttrs: {
hash = "sha256-UCuQMWGwe+YxeGj0Y6m5IT58NW2lAWN5RqyZnvyFSr4=";
};

strictDeps = true;

# remove attempt to prevent (x86/x87-specific) extended precision use
# when SSE not detected
postPatch = lib.optionalString (!stdenv.hostPlatform.isx86) ''
Expand All @@ -59,8 +61,7 @@ stdenv.mkDerivation (finalAttrs: {
libpcap
libsForQt5.qtbase
libusb1
llvmPackages.openmp
];
] ++ lib.optionals stdenv.cc.isClang [ llvmPackages.openmp ];

propagatedBuildInputs = [
boost
Expand All @@ -71,8 +72,11 @@ stdenv.mkDerivation (finalAttrs: {
vtk
];

cmakeFlags = lib.optionals cudaSupport [
(lib.cmakeBool "WITH_CUDA" true)
cmakeFlags = [
(lib.cmakeBool "BUILD_CUDA" cudaSupport)
(lib.cmakeBool "BUILD_GPU" cudaSupport)
(lib.cmakeBool "PCL_ENABLE_MARCHNATIVE" false)
(lib.cmakeBool "WITH_CUDA" cudaSupport)
];

passthru.updateScript = gitUpdater {
Expand Down