Merged
Conversation
github-actions
bot
added
10.rebuild-darwin: 1-10
FliegendeWurst
approved these changes
Jan 19, 2025
Member
FliegendeWurst
left a comment
FliegendeWurst
left a comment
There was a problem hiding this comment.
Boost needs to be pinned to 1.86 due to use of boost::asio::io_service
I can do it in another PR or you can update it here.
wegank
added
the
12.approvals: 1
Contributor
Author
|
Support for Boost 1.87 was added in this PR: PointCloudLibrary/pcl#6166 I added it to |
Contributor
Author
|
Contributor
Author
|
wegank
removed
the
12.approvals: 1
wegank
added
the
2.status: merge conflict
Member
|
The update was done in #382027. If you are still interested in the CUDA changes, please rebase. |
The documentation [1] and upstream CI [2] define additional flags to enable CUDA support. [1]: https://pointclouds.org/documentation/tutorials/gpu_install.html [2]: https://github.com/PointCloudLibrary/pcl/blob/d3769b16170f73df40fc23bb7473b5f2fdcfac06/.ci/azure-pipelines/build/ubuntu.yaml
This defaults to true, which causes the CC wrappers to issue warnings: warning: Skipping impure flag -march=native because NIX_ENFORCE_NO_NATIVE is set
ofborg
bot
removed
the
2.status: merge conflict
github-actions
bot
added
the
10.rebuild-darwin: 1
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CUDA support is untested but it does build successfully.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.