Skip to content

streamripper: fix compilation #373144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CyberShadow wants to merge 1 commit into from
Closed

streamripper: fix compilation #373144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions pkgs/by-name/st/streamripper/fix-compilation.patch
View file
Open in desktop
Copy link
Member

@Aleksanaa Aleksanaa Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a source we can use/cite from?

Copy link
Member Author

@CyberShadow CyberShadow Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, source for what? I wrote this patch myself.

If it helps, here's Debian's patch: https://salsa.debian.org/debian/streamripper/-/blob/master/debian/patches/1075541-gcc14?ref_type=heads

Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
diff --git a/lib/argv.c b/lib/argv.c
index 42b260b..efcd8c6 100644
--- a/lib/argv.c
+++ b/lib/argv.c
@@ -70,6 +70,7 @@ extern char *malloc (); /* Standard memory allocater */
extern char *realloc (); /* Standard memory reallocator */
extern void free (); /* Free malloc'd memory */
extern char *strdup (); /* Duplicate a string */
+extern char *strcpy (); /* Copy a string */
#endif

#endif /* ANSI_PROTOTYPES */
4 changes: 4 additions & 0 deletions pkgs/by-name/st/streamripper/package.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ stdenv.mkDerivation rec {
sha256 = "0hnyv3206r0rfprn3k7k6a0j959kagsfyrmyjm3gsf3vkhp5zmy1";
};

patches = [
./fix-compilation.patch
];

nativeBuildInputs = [ pkg-config ];
buildInputs = [
glib
Expand Down