Skip to content

streamripper: fix compilation#373144

Closed
CyberShadow wants to merge 1 commit intoNixOS:masterfrom
CyberShadow:streamripper-fix-compilation
Closed

streamripper: fix compilation#373144
CyberShadow wants to merge 1 commit intoNixOS:masterfrom
CyberShadow:streamripper-fix-compilation

Conversation

@CyberShadow
Copy link
Member

Compilation was failing with:

lib/argv.c: In function 'dupargv':
lib/argv.c:126:7: error: implicit declaration of function 'strcpy' [8;;https://gcc.gnu.org/onlinedocs/gcc-14.2.0/gcc/Warning-Options.html#index-Wimplicit-function-declaration-Wimplicit-function-declaration8;;]
  126 |       strcpy (copy[argc], argv[argc]);
      |       ^~~~~~

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 12, 2025
@ofborg ofborg bot added the ofborg-internal-error Ofborg encountered an error label Jan 12, 2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a source we can use/cite from?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, source for what? I wrote this patch myself.

If it helps, here's Debian's patch: https://salsa.debian.org/debian/streamripper/-/blob/master/debian/patches/1075541-gcc14?ref_type=heads

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. ofborg-internal-error Ofborg encountered an error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants