sage.lib, sage.test: clang-19 / darwin fixes#370822
sage.lib, sage.test: clang-19 / darwin fixes#370822collares merged 2 commits intoNixOS:masterfrom paparodeo:sage-fixes-darwin
Conversation
`https://github.com/sagemath/sage/pull/39249` The v_index type is an integer and in the code there are lots of places where the significant bytes of an 8 byte type are lost in assignment. However, this is the only one which causes an error. A workaround is to ignore the error or to preform the assignment outside of the initializer list.
|
Thanks, this is really great! Assuming running By the way, one tangentially-related question since you have the hardware to test it (obviously this won't block this PR): We currently have a patch disabling some Singular doctests on Clang due to stack overflows ( |
from an older sage using lcalc namespace
building now. unfortunately removing the patch requires a sagelib rebuild. |
Thank you very much! This won't block the present PR, of course. Merging. |
the patch is still needed, unfortunately |
|
Thanks for checking! |
adds
NIX_CFLAGS_COMPILE = "-Wno-error=c++11-narrowing-const-reference";to workaround sagemath/sage#39249and some changes in
sage.testto allow tests to succeed in sandbox.once #370545 is merged sage should compile on darwin again (running now, have build with this change and a different lcalc fix).
given sage builds singular with a
flint3without blas the link error in that is seen in standalone singular https://hydra.nixos.org/build/283880696 does not exist. (I have various fixes for it but no need to hold off fixing sage for them)Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.