lcalc: use libc++-compatible way of extending namespace std#370545
Merged
collares merged 1 commit intoNixOS:masterfrom Jan 4, 2025
Merged
lcalc: use libc++-compatible way of extending namespace std#370545collares merged 1 commit intoNixOS:masterfrom
collares merged 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
10.rebuild-darwin: 1-10
collares
changed the title
13 tasks
paparodeo
approved these changes
Jan 4, 2025
Contributor
paparodeo
left a comment
paparodeo
left a comment
There was a problem hiding this comment.
compiled fine for me on clang-19 / darwin
13 tasks
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I suggested something in #370176 and didn't test it properly on libc++, and it wasn't enough to fix the Sage build. Let's try an alternate fix. Another possible fix is available at #370547, along with discussion of the tradeoffs between the two.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.