Skip to content

docs: remove outdated references to CODEOWNERS #369505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
infinisil merged 2 commits into from
Dec 30, 2024
Merged

docs: remove outdated references to CODEOWNERS #369505

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb72703
docs: remove outdated references to CODEOWNERS
me-and Dec 30, 2024
bd98340
docs: correct CODEOWNERS to OWNERS
me-and Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion maintainers/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ for the maintainers to provide feedback.

For critical packages, this convention needs to be negotiated with the
maintainer. A critical package is one that causes mass-rebuild, or where an
author is listed in the [`CODEOWNERS`](../.github/CODEOWNERS) file.
author is listed in the [`OWNERS`](../ci/OWNERS) file.
Comment on lines 24 to +26

@SigmaSquadron SigmaSquadron Dec 30, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this whole paragraph has been wrong for a while. OWNERS is for things that don't have a meta.maintainers as well, that may or may not be critical.

@SigmaSquadron SigmaSquadron Dec 30, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I don't want this to be a blocking comment. We can rewrite it in another PR.


In case of critical security updates, the [security team](https://nixos.org/community/teams/security) might override these
heuristics in order to get the fixes in as fast as possible.
Expand Down
2 changes: 1 addition & 1 deletion nixos/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ Module updates are submissions changing modules in some ways. These often contai
Reviewing process:

- Ensure that the module maintainers are notified.
- [CODEOWNERS](https://help.github.com/articles/about-codeowners/) will make GitHub notify users based on the submitted changes, but it can happen that it misses some of the package maintainers.
- The continuous integration system will make GitHub notify users based on the submitted changes, but it can happen that it misses some of the package maintainers.
- Ensure that the module tests, if any, are succeeding.
- You may invoke OfBorg with `@ofborg test <module>` to build `nixosTests.<module>`
- Ensure that the introduced options are correct.
Expand Down
2 changes: 1 addition & 1 deletion pkgs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -914,7 +914,7 @@ Reviewing process:
- Ensure that the package versioning [fits the guidelines](#versioning).
- Ensure that the commit text [fits the guidelines](../CONTRIBUTING.md#commit-conventions).
- Ensure that the package maintainers are notified.
- [CODEOWNERS](https://help.github.com/articles/about-codeowners) will make GitHub notify users based on the submitted changes, but it can happen that it misses some of the package maintainers.
- The continuous integration system will make GitHub notify users based on the submitted changes, but it can happen that it misses some of the package maintainers.
- Ensure that the meta field information [fits the guidelines](#meta-attributes) and is correct:
- License can change with version updates, so it should be checked to match the upstream license.
- If the package has no maintainer, a maintainer must be set. This can be the update submitter or a community member that accepts to take maintainership of the package.
Expand Down
2 changes: 1 addition & 1 deletion pkgs/development/haskell-modules/HACKING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,5 +351,5 @@ Here are some additional tips that didn't fit in above.
and work the new member into the `haskell-updates` rotation.

1. Optionally, have the new member add themselves to the Haskell
section in [`CODEOWNERS`](../../../.github/CODEOWNERS). This
section in [`OWNERS`](../../../ci/CODEOWNERS). This
Comment thread
me-and marked this conversation as resolved.
Outdated
will cause them to get pinged on most Haskell-related PRs.