docs: remove outdated references to CODEOWNERS#369505
Merged
infinisil merged 2 commits intoNixOS:masterfrom Dec 30, 2024
Merged
docs: remove outdated references to CODEOWNERS#369505infinisil merged 2 commits intoNixOS:masterfrom
infinisil merged 2 commits intoNixOS:masterfrom
Conversation
As of b01ca00 (CODEOWNERS: Switch to alternate mechanism, 2024-10-10) and NixOS#336261, this repository doesn't use the GitHub CODEOWNERS file, but instead has its own similar mechanism. Remove and update references to the CODEOWNERS file in various documentation files.
github-actions
bot
added
6.topic: nixos
github-actions
bot
added
10.rebuild-darwin: 0
Comment on lines
24
to
+26
| For critical packages, this convention needs to be negotiated with the | ||
| maintainer. A critical package is one that causes mass-rebuild, or where an | ||
| author is listed in the [`CODEOWNERS`](../.github/CODEOWNERS) file. | ||
| author is listed in the [`OWNERS`](../ci/OWNERS) file. |
Contributor
There was a problem hiding this comment.
I feel like this whole paragraph has been wrong for a while. OWNERS is for things that don't have a meta.maintainers as well, that may or may not be critical.
Contributor
There was a problem hiding this comment.
But I don't want this to be a blocking comment. We can rewrite it in another PR.
Co-authored-by: Fernando Rodrigues <alpha@sigmasquadron.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of b01ca00 (CODEOWNERS: Switch to alternate mechanism, 2024-10-10) and #336261, this repository doesn't use the GitHub CODEOWNERS file, but instead has its own similar mechanism. Remove and update references to the CODEOWNERS file in various documentation files.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.