Merged
Conversation
github-actions
bot
added
10.rebuild-darwin: 101-500
ofborg
bot
added
11.by: package-maintainer
stigtsp
force-pushed
the
gnupg-freepg
branch
from
0d1368a to
447c3ce
Compare
github-actions
bot
added
10.rebuild-darwin: 101-500
ofborg
bot
added
10.rebuild-darwin: 501+
ofborg
bot
added
the
2.status: merge conflict
stigtsp
force-pushed
the
gnupg-freepg
branch
from
570332a to
addd12c
Compare
github-actions
bot
added
10.rebuild-darwin: 101-500
stigtsp
force-pushed
the
gnupg-freepg
branch
2 times, most recently
from
ca54d44 to
7ac027e
Compare
fpletz
removed
the
2.status: merge conflict
fpletz
approved these changes
Dec 29, 2024
Member
fpletz
left a comment
fpletz
left a comment
There was a problem hiding this comment.
Haven't tested this yet but 👍 on introducing the freepg patches.
Add patches to GnuPG 2.4 from FreePG, a common resource for GnuPG downstream packagers to track, maintain, and apply commonly-used patches for GnuPG that have been refused by upstream. The purpose of adding these patches to nixpkgs is to ensure compatibility with other OpenPGP tools. https://gitlab.com/freepg/gnupg/
stigtsp
force-pushed
the
gnupg-freepg
branch
from
7ac027e to
0d7cdd8
Compare
ofborg
bot
added
10.rebuild-darwin: 501+
emilazy
approved these changes
Jan 5, 2025
Member
emilazy
left a comment
emilazy
left a comment
There was a problem hiding this comment.
Sad that this is necessary, but I agree that it’s a good idea. I’ve confirmed the build on x86_64-darwin (rebased on top of master). Two non‐blocking comments for the future.
| domain = "gitlab.com"; | ||
| owner = "freepg"; | ||
| repo = "gnupg"; | ||
| rev = "541772915dc4ec832c37f85bc629a22051f0e8f7"; |
Member
There was a problem hiding this comment.
Upstream have tags corresponding to GnuPG releases; it would be nice if we could convince them to also tag the branch with the patch files in them in future. Or we could just source directly from their patched tags.
Comment on lines
+86
to
+94
| "0002-gpg-accept-subkeys-with-a-good-revocation-but-no-sel.patch" | ||
| "0003-gpg-allow-import-of-previously-known-keys-even-witho.patch" | ||
| "0004-tests-add-test-cases-for-import-without-uid.patch" | ||
| "0005-gpg-drop-import-clean-from-default-keyserver-import-.patch" | ||
| "0006-Do-not-use-OCB-mode-even-if-AEAD-OCB-key-preference-.patch" | ||
| "0007-Revert-the-introduction-of-the-RFC4880bis-draft-into.patch" | ||
| "0008-avoid-systemd-deprecation-warning.patch" | ||
| "0009-Add-systemd-support-for-keyboxd.patch" | ||
| "0010-doc-Remove-profile-and-systemd-example-files.patch" |
Member
There was a problem hiding this comment.
I don’t know if globs work here, but if not perhaps we could do it manually in postPatch instead, to ensure that we never miss a new patch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add patches to GnuPG 2.4 from FreePG, a common resource for GnuPG downstream packagers to track, maintain, and apply commonly-used patches for GnuPG that have been refused by upstream.
The purpose of adding these patches to nixpkgs is to ensure compatibility with other OpenPGP tools.
https://gitlab.com/freepg/gnupg/
Arch Linux is also doing the same:
https://gitlab.archlinux.org/archlinux/packaging/packages/gnupg/-/merge_requests/8
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.