Skip to content

Add GnuPG 2.5.2#365221

Closed
lunaticare wants to merge 12 commits intoNixOS:masterfrom
lunaticare:feature/gnupg_25
Closed

Add GnuPG 2.5.2#365221
lunaticare wants to merge 12 commits intoNixOS:masterfrom
lunaticare:feature/gnupg_25

Conversation

@lunaticare
Copy link
Contributor

@lunaticare lunaticare commented Dec 14, 2024 •
edited
Loading

  • add GnuPG 2.5.2 which introduces experimental support for the Kyber post-quantum cryptoghraphy algorithm
  • add libassuan 3.0.1
  • libgcrypt 1.10.3 -> 1.11.0
  • libgpg-error 1.50 -> 1.51

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/ bin/)
    • gpg --full-gen-key
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Dec 14, 2024
@lunaticare lunaticare marked this pull request as ready for review December 14, 2024 19:51
dotlambda
dotlambda requested changes Dec 14, 2024
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please target staging and follow the commit guidelines.

pkgs/by-name/gn/gnupg_2_5/package.nix

assert guiSupport -> !enableMinimal;
let
libassuan = libassuan_3;
Copy link
Member

@dotlambda dotlambda Dec 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #364132

pkgs/by-name/li/libgpg-error/package.nix
stdenv.mkDerivation (rec {
pname = "libgpg-error";
version = "1.50";
version = "1.51";
Copy link
Member

@dotlambda dotlambda Dec 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #361339

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Dec 15, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. and removed 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. labels Dec 15, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 15, 2025
x10an14
x10an14 reviewed Feb 15, 2025
View reviewed changes
Copy link
Contributor

@x10an14 x10an14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After #368275, a change like this might need to wait for 2.5 upstream changes to percolate through the https://gitlab.com/freepg/gnupg source first

@lunaticare lunaticare closed this Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dotlambda dotlambda dotlambda requested changes

@fpletz fpletz Awaiting requested review from fpletz

@bjornfor bjornfor Awaiting requested review from bjornfor

@prusnak prusnak Awaiting requested review from prusnak

@stigtsp stigtsp Awaiting requested review from stigtsp

@amiloradovsky amiloradovsky Awaiting requested review from amiloradovsky

@gebner gebner Awaiting requested review from gebner

+1 more reviewer

@x10an14 x10an14 x10an14 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lunaticare @x10an14 @dotlambda @wegank