Skip to content

gpu-screen-recorder{,-gtk}: add passthru.updateScript, update #367552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pbsds merged 7 commits into from
Jun 6, 2025
Merged

gpu-screen-recorder{,-gtk}: add passthru.updateScript, update #367552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e39a299
gpu-screen-recorder{,-gtk}: move to pkgs/by-name
js6pak Jan 5, 2025
2f3a205
gpu-screen-recorder{,-gtk}: add passthru.updateScript
js6pak Dec 23, 2024
ee02281
gpu-screen-recorder{,-gtk}: use fetchgit instead of fetchurl
js6pak Jan 5, 2025
9bfb3e7
gpu-screen-recorder{,-gtk}: add myself as maintainer
js6pak Jan 5, 2025
6fe3a61
gpu-screen-recorder: 5.2.0 -> 5.5.3
js6pak Feb 2, 2025
f18cf01
nixos/gpu-screen-recorder: add `cap_sys_nice` back
js6pak May 11, 2025
110d7b2
gpu-screen-recorder-gtk: 5.1.6 -> 5.7.0
js6pak Feb 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions nixos/modules/programs/gpu-screen-recorder.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,12 @@ in
capabilities = "cap_sys_admin+ep";
source = "${package}/bin/gsr-kms-server";
};
security.wrappers."gpu-screen-recorder" = {
owner = "root";
group = "root";
capabilities = "cap_sys_nice+ep";
source = "${package}/bin/gpu-screen-recorder";
};
};

meta.maintainers = with lib.maintainers; [ timschumi ];
Expand Down
25 changes: 15 additions & 10 deletions ...reen-recorder/gpu-screen-recorder-gtk.nix → ...me/gp/gpu-screen-recorder-gtk/package.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
stdenv,
lib,
fetchurl,
fetchgit,
pkg-config,
addDriverRunpath,
desktop-file-utils,
Expand All @@ -19,19 +19,19 @@
wayland,
wrapGAppsHook3,
wrapperDir ? "/run/wrappers/bin",
gitUpdater,
}:

stdenv.mkDerivation (finalAttrs: {
stdenv.mkDerivation rec {

@donovanglover donovanglover Feb 8, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
stdenv.mkDerivation rec {
stdenv.mkDerivation (finalAttrs: {

https://discourse.nixos.org/t/avoid-rec-expresions-in-nixpkgs/8293

@js6pak js6pak Feb 8, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using finalAttrs instead of rec for version here would lead to #310373. I don't think there is a consensus on the best solution, but rec works fine here.

pname = "gpu-screen-recorder-gtk";
version = "5.1.6";
version = "5.7.0";

src = fetchurl {
url = "https://dec05eba.com/snapshot/gpu-screen-recorder-gtk.git.${finalAttrs.version}.tar.gz";
hash = "sha256-op5cDILQglVAW/oajc0rdrMC02JZZ8bdER1B1qWPkSk=";
src = fetchgit {
url = "https://repo.dec05eba.com/${pname}";

@donovanglover donovanglover Feb 8, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
url = "https://repo.dec05eba.com/${pname}";
url = "https://repo.dec05eba.com/gpu-screen-recorder-gtk";

#277994

@js6pak js6pak Feb 8, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rec being constant doesn't introduce any overriding traps here, so whether you use ${pname} or a literal value is a subjective choice. Imo this is nicer because it can be shared across all gpu-screen-recorder-* packages.

tag = version;
hash = "sha256-/s8FCV3hE7Gq1Ad6EhRNTZJwyskV+uRYvjJ43298AOw=";
};

sourceRoot = ".";

nativeBuildInputs = [
desktop-file-utils
pkg-config
Expand Down Expand Up @@ -68,13 +68,18 @@ stdenv.mkDerivation (finalAttrs: {
})
'';

passthru.updateScript = gitUpdater { };

meta = {
changelog = "https://git.dec05eba.com/gpu-screen-recorder-gtk/tree/com.dec05eba.gpu_screen_recorder.appdata.xml#n82";
description = "GTK frontend for gpu-screen-recorder.";
homepage = "https://git.dec05eba.com/gpu-screen-recorder-gtk/about/";
license = lib.licenses.gpl3Only;
mainProgram = "gpu-screen-recorder-gtk";
maintainers = with lib.maintainers; [ babbaj ];
maintainers = with lib.maintainers; [
babbaj
js6pak
];
platforms = [ "x86_64-linux" ];
};
})
}
27 changes: 17 additions & 10 deletions ...ons/video/gpu-screen-recorder/default.nix → ...y-name/gp/gpu-screen-recorder/package.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
stdenv,
lib,
fetchurl,
fetchgit,
makeWrapper,
meson,
ninja,
Expand All @@ -12,6 +12,7 @@
dbus,
ffmpeg,
wayland,
wayland-scanner,
vulkan-headers,
pipewire,
libdrm,
Expand All @@ -22,19 +23,19 @@
libXrandr,
libXfixes,
wrapperDir ? "/run/wrappers/bin",
gitUpdater,
}:

stdenv.mkDerivation (finalAttrs: {
stdenv.mkDerivation rec {
pname = "gpu-screen-recorder";
version = "5.2.0";
version = "5.5.3";

src = fetchurl {
url = "https://dec05eba.com/snapshot/gpu-screen-recorder.git.${finalAttrs.version}.tar.gz";
hash = "sha256-7aUW0WhoTpkJhj9WjjI2lnq+vOCG53vl/4DckHmLPBo=";
src = fetchgit {
url = "https://repo.dec05eba.com/${pname}";
tag = version;
hash = "sha256-XXSHTS/WWqGblbBLuzHSYCY5FVTDSHBHfBWubmoNSy0=";
};

sourceRoot = ".";

nativeBuildInputs = [
pkg-config
makeWrapper
Expand All @@ -49,6 +50,7 @@ stdenv.mkDerivation (finalAttrs: {
ffmpeg
pipewire
wayland
wayland-scanner
vulkan-headers
libdrm
libva
Expand Down Expand Up @@ -82,12 +84,17 @@ stdenv.mkDerivation (finalAttrs: {
--suffix PATH : "$out/bin"
'';

passthru.updateScript = gitUpdater { };

meta = {
description = "Screen recorder that has minimal impact on system performance by recording a window using the GPU only";
homepage = "https://git.dec05eba.com/gpu-screen-recorder/about/";
license = lib.licenses.gpl3Only;
mainProgram = "gpu-screen-recorder";
maintainers = [ lib.maintainers.babbaj ];
maintainers = with lib.maintainers; [
babbaj
js6pak
];
platforms = [ "x86_64-linux" ];
};
})
}
6 changes: 0 additions & 6 deletions pkgs/top-level/all-packages.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12721,12 +12721,6 @@ with pkgs;
withDoc = true;
};

gpu-screen-recorder = callPackage ../applications/video/gpu-screen-recorder { };

gpu-screen-recorder-gtk =
callPackage ../applications/video/gpu-screen-recorder/gpu-screen-recorder-gtk.nix
{ };

gpxsee-qt5 = libsForQt5.callPackage ../applications/misc/gpxsee { };

gpxsee-qt6 = qt6Packages.callPackage ../applications/misc/gpxsee { };
Expand Down