gpu-screen-recorder{,-gtk}: add passthru.updateScript, update

[js6pak]

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[keenanweaver]

Don't know how to test it locally, but it looks great.

[keenanweaver]

5.0.0 is now out: https://git.dec05eba.com/gpu-screen-recorder/

[js6pak]

There is also gpu-screen-recorder-ui now, which is interesting

[keenanweaver]

There is also gpu-screen-recorder-ui now, which is interesting

I was just opening a packaging request for this. Looks like someone already did some preliminary work: https://github.com/Nowaaru/nix-diary/tree/6230e94b178924e7455a1dc0d318f50e10c8aec6/modules/gpu-screen-recorder/packages.

The module would probably need to be updated as well.

[keenanweaver]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 367552

---

x86_64-linux

✅ 2 packages built:

• gpu-screen-recorder
• gpu-screen-recorder-gtk

[donovanglover]

Suggested change

	stdenv.mkDerivation rec {
	stdenv.mkDerivation (finalAttrs: {

https://discourse.nixos.org/t/avoid-rec-expresions-in-nixpkgs/8293

[js6pak]

Using finalAttrs instead of rec for version here would lead to #310373. I don't think there is a consensus on the best solution, but rec works fine here.

[donovanglover]

Suggested change

	url = "https://repo.dec05eba.com/${pname}";
	url = "https://repo.dec05eba.com/gpu-screen-recorder-gtk";

#277994

[js6pak]

rec being constant doesn't introduce any overriding traps here, so whether you use ${pname} or a literal value is a subjective choice. Imo this is nicer because it can be shared across all gpu-screen-recorder-* packages.

[js6pak]

So... how do I get this merged?

[keenanweaver]

So... how do I get this merged?

Basically have to wait for a committer to review and merge. You could try posting that the PR is ready for review in this thread which I've seen speed up PR reviews. Afraid there's not much else aside from pinging committers which I think is considered taboo.

[keenanweaver]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 367552

---

x86_64-linux

✅ 2 packages built:

• gpu-screen-recorder
• gpu-screen-recorder-gtk

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5256

[Gliczy]

I'm not sure why ofborg-eval failed, but this still compiles and run fine.

[keenanweaver]

The GTK app is no longer being developed.

No need to drop from nixpkgs yet, just something to note.

[js6pak]

I have added cap_sys_nice back (6480b974fb06df577a7a40ab9a7768477b16e940) since 5.5.2 is supposed to fix the issue it caused for portal capture, but it still doesn't work for me.

❯ ./result/bin/gpu-screen-recorder --list-capture-options /dev/dri/card0 amd
DP-1|3840x2160
DP-2|2560x1440
region
portal

❯ /run/wrappers/bin/gpu-screen-recorder --list-capture-options /dev/dri/card0 amd
DP-1|3840x2160
DP-2|2560x1440
region
gsr error: gsr_dbus_call_screencast_method: failed with error: Portal operation not allowed: Unable to open /proc/440809/root
gsr error: gsr_dbus_screencast_create_session: failed to setup ScreenCast session. Make sure you have a desktop portal running with support for the ScreenCast interface and that the desktop portal matches the Wayland compositor you are running.
gsr error: gsr_dbus_client_screencast_create_session: server return error: Failed to handle request (-1)

I guess that's caused by our security wrappers making the capabilities ambient?

nixpkgs/nixos/modules/security/wrappers/wrapper.c

Line 199 in c542760

if (make_caps_ambient("/proc/self/exe") != 0) {

[dec05eba]

Hmm seems like it. The fix in 5.5.2 was to move that dbus code to another process (a child process) that runs the included program gsr-dbus-server. Normally a child process doesn't inherit the capability of the parent process since it has cap_sys_nice+ep as opposed to cap_sys_nice+eip.

[js6pak]

Adding a prctl(PR_CAP_AMBIENT, PR_CAP_AMBIENT_CLEAR_ALL, 0, 0, 0); before the execvp here https://git.dec05eba.com/gpu-screen-recorder/tree/dbus/client/dbus_client.c?h=5.5.2&id=0ae5b83e476ed6345c536a438ce5d61e60a11f45#n70, seems to work, but definitely feels hacky.

[dec05eba]

I'll add that then. As long as it works!

[js6pak]

@dec05eba Also, how would I test that cap_sys_nice actually works?

[dec05eba]

@js6pak I added the ambient fix you mentioned and released it as part of 5.5.3. With that version it also mentions if cap_sys_nice is not working. If it's not working then it outputs this when you run gpu-screen-recorder --info for example:

amdgpu: amdgpu_cs_ctx_create2 failed. (-13)
gsr warning: cap_sys_nice capability is missing on the gpu-screen-recorder binary, performance might be affected. If you are using the flatpak version of gpu-screen-recorder then the only fix is to use a non-flatpak version of gpu-screen-recorder

[js6pak]

Both cap_sys_nice and portal capture are working now. Thanks @dec05eba!

[keenanweaver]

Still functioning great. I'm hoping this can finally be merged along with #369574

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 367552

---

x86_64-linux

⏩ 2 packages blacklisted:

• nixos-install-tools
• tests.nixos-functions.nixos-test

✅ 2 packages built:

• gpu-screen-recorder
• gpu-screen-recorder-gtk

[pbsbot]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 367552
Commit: 110d7b29b30208a6aaa4e95b8c878e3d6e4c0709

---

x86_64-linux

⏩ 2 packages blacklisted:

• nixos-install-tools
• tests.nixos-functions.nixos-test

✅ 2 packages built:

• gpu-screen-recorder
• gpu-screen-recorder-gtk