Skip to content

buildEnv: fix bulder.pl (addPkg argument ignoreSingleFileOutputs)#363710

Merged
philiptaron merged 1 commit intoNixOS:staging-nextfrom
ShamrockLee:buildenv-isfo-hotfix
Dec 10, 2024
Merged

buildEnv: fix bulder.pl (addPkg argument ignoreSingleFileOutputs)#363710
philiptaron merged 1 commit intoNixOS:staging-nextfrom
ShamrockLee:buildenv-isfo-hotfix

Conversation

@ShamrockLee
Copy link
Contributor

This PR adds specifications of parameter ignoreSingleFileOutputs wherever calling the Perl function addPkg in buildenv/builder.pl.

Now vim.customize { vimrcConfig = { }; } builds successfully.

This is a leftover of #353752. Sorry for the breakage caused by my loose ends.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Specify the ignoreSingleFileOutputs parameter wherever calling addPkg.
@ShamrockLee ShamrockLee requested review from K900 and yu-re-ka December 9, 2024 20:26
@nix-owners nix-owners bot requested a review from philiptaron December 9, 2024 20:28
@philiptaron philiptaron merged commit 0396ae7 into NixOS:staging-next Dec 10, 2024
vcunat added a commit that referenced this pull request Dec 10, 2024
We've lost most of finished binaries due to a buildEnv fix (#363710),
e.g. rebuilding darwin stdenvs, so let's pull more of `staging`, too.
@wolfgangwalther wolfgangwalther mentioned this pull request Dec 30, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants