buildEnv: support ignoreSingleFileOutputs (resumed)#353752
buildEnv: support ignoreSingleFileOutputs (resumed)#353752philiptaron merged 1 commit intoNixOS:stagingfrom
Conversation
Mic92
left a comment
There was a problem hiding this comment.
Would be cool to have this because it's not possible from pure nix to know wether a derivation is a single file.
I think we should enforce a policy to exclude all single-file outputs from |
|
@ShamrockLee, I'd like to merge this once the merge conflict is resolved. |
793c7f2 to
3843aed
Compare
|
The PR's base branch is set to staging, but 248 commits from the master branch are included. Make sure you know the right base branch for your changes, then:
|
3843aed to
6bacc2f
Compare
|
@philiptaron Rebased. |
|
@Mic92 @philiptaron Regarding the argument name, do you think it should be |
|
I'm amenable to both, but |
6bacc2f to
5ca3e70
Compare
|
Renamed! |
philiptaron
left a comment
There was a problem hiding this comment.
One copy-editing nit on a comment.
Add option to ignore single-file output instead of failing.
83eb710 to
70038f0
Compare
|
Rebasd and squashed the commit. |
Add option to ignore single-file output instead of failing, which would be useful to fix Mic92/nixpkgs-review#408.
Cc: @corngood
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.