Skip to content

kernel-headers: remove deprecated and broken asm symlink fixups#36366

Merged
dtzWill merged 1 commit intoNixOS:stagingfrom
dtzWill:fix/kernel-header-asm-symlinks-remove
Mar 11, 2018
Merged

kernel-headers: remove deprecated and broken asm symlink fixups#36366
dtzWill merged 1 commit intoNixOS:stagingfrom
dtzWill:fix/kernel-header-asm-symlinks-remove

Conversation

@dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 6, 2018

Replaces #36303.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Mar 6, 2018
@dezgeg
Copy link
Contributor

dezgeg commented Mar 6, 2018

LGTM, though you could have a link to the discussion in #36303 on the commit message.

BTW, staging has quite a bit of unmerged stuff so might not want to merge this just yet.

@dtzWill dtzWill force-pushed the fix/kernel-header-asm-symlinks-remove branch from 974ff77 to 3a40b33 Compare March 6, 2018 17:14
@dtzWill
Copy link
Member Author

dtzWill commented Mar 6, 2018

Good call, updated the commit. Happy to wait re:merging to staging, but not sure how to know when it's in a better condition. Should I just ping this in a few days? :)

cc NixOS/rfcs#26 re:staging workflow .

(this is low-priority but will cause lots of rebuilds, while also being rather low risk in terms of "let's see if anything breaks")

@dtzWill dtzWill merged commit 0e01430 into NixOS:staging Mar 11, 2018
@dtzWill dtzWill deleted the fix/kernel-header-asm-symlinks-remove branch March 11, 2018 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants