Conversation
|
Did you notice anything broken? Maybe nothing actually needs this? |
|
Haven't noticed anything broken, but without knowing/exploring why this was done originally seemed best to fix it :). If we're sure it's not useful we can remove this entirely. Maybe it only helps with broken code? Dunno. |
|
Well, git shows:
|
|
Do we need the other one, asm-x86_64 etc that's created as well? Or we're they both introduced with that commit? |
|
Seems to be even older stuff, that directory got removed in Linux 2.6.24. In nixpkgs that seemed to be needed for the out-of-tree (back then) KVM like was mentioned the above commit. |
|
Okay so looks like the answer is dropping this fixup entirely! I'll hopefully submit a PR for that soon but feel free if I take too long, got a lot on my plate :3. |
We no longer set "platform", so the code referring to it
did the wrong thing.
Happened to notice that we created an "asm-" symlink.
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)