Skip to content

[Backport staging-24.11] Reapply: rav1e: remove build-time dependency on libgit2#362712

Merged
mweinelt merged 1 commit intoNixOS:staging-24.11from
getchoo-contrib:backport-360999-to-staging-24.11
Dec 31, 2024
Merged

[Backport staging-24.11] Reapply: rav1e: remove build-time dependency on libgit2#362712
mweinelt merged 1 commit intoNixOS:staging-24.11from
getchoo-contrib:backport-360999-to-staging-24.11

Conversation

@getchoo
Copy link
Member

@getchoo getchoo commented Dec 7, 2024

(cherry picked from commit b80ae99)

Manual backport of #360999 as staging saw some other changes that weren't backported

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

* rav1e: remove build-time dependency on libgit2

* rav1e: use new Darwin SDK pattern

* rav1e: removed unused cargo patch

---------

Co-authored-by: Theodore Ni <3806110+tjni@users.noreply.github.com>
(cherry picked from commit b80ae99)
@github-actions github-actions bot added 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Dec 7, 2024
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. and removed 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. labels Dec 8, 2024
@mweinelt mweinelt merged commit 404b87d into NixOS:staging-24.11 Dec 31, 2024
@getchoo getchoo deleted the backport-360999-to-staging-24.11 branch December 31, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants