Reapply: rav1e: remove build-time dependency on libgit2#360999
Merged
getchoo merged 3 commits intoNixOS:stagingfrom Dec 5, 2024
paparodeo:rav1e-devendor-better
Merged
Reapply: rav1e: remove build-time dependency on libgit2#360999getchoo merged 3 commits intoNixOS:stagingfrom paparodeo:rav1e-devendor-better
getchoo merged 3 commits intoNixOS:stagingfrom
paparodeo:rav1e-devendor-better
Conversation
getchoo
approved these changes
Dec 2, 2024
Member
getchoo
left a comment
There was a problem hiding this comment.
Built against nixos-unstable and everything works as expected. Thanks!
Contributor
Author
getchoo
approved these changes
Dec 3, 2024
tjni
approved these changes
Dec 5, 2024
Contributor
tjni
left a comment
There was a problem hiding this comment.
Thank you for following up on this!
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin staging-24.11
git worktree add -d .worktree/backport-360999-to-staging-24.11 origin/staging-24.11
cd .worktree/backport-360999-to-staging-24.11
git switch --create backport-360999-to-staging-24.11
git cherry-pick -x b80ae990684936b8c84825e27929cb5b11483dec |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
re-apply #355325 which is a better way to de-vendor libgit2 but had to be reverted on master due to mass-builds.
files are identical after this PR and #355325
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.
@emilazy
@tjni