Conversation
7f4b435 to
11ea53c
Compare
|
Build fails with download error. Similar issue when trying to update the cache: |
|
Seems due to that repository shutting down. |
|
The download issues are fixed with version 5.4, now it fails with: |
FliegendeWurst
left a comment
There was a problem hiding this comment.
Program launches, did not test further.
There was a problem hiding this comment.
I am not sure you need the smaller sizes
There was a problem hiding this comment.
Not sure either what the typical sizes should be. Will do whatever you think is appropriate.
Another option would be to use the upstream ico file and take all the sizes from there, e.g. like this:
mapfile -t iconSizes < <(magick identify -format '%wx%h\n' app/res/all-icons-256.ico)
i=0
for iconSize in "''${iconSizes[@]}"; do
magick convert app/res/all-icons-256.ico"[$((i++))]" +set date:create +set date:modify icon.png
install -D -m0644 icon.png "$out/share/icons/hicolor/$iconSize/apps/audiveris.png"
doneThere was a problem hiding this comment.
Extracting them from the ico sounds good, yes. FWIW I don't know of any software that would need X px icons if Y px icons (Y > X) are available. I see lots of derivations that just install one size (256px for example), and nobody complained so far.
There was a problem hiding this comment.
| Exec=$out/bin/audiveris | |
| Exec=audiveris |
This is preferred #308324.
Even better would be to use createDesktopItem and copyDesktopItems.
There was a problem hiding this comment.
This is much better! Done.
There was a problem hiding this comment.
To make it less confusing you could set the last one to "nixpkgs" (line 47).
Co-authored-by: FliegendeWurst <arne.keller@posteo.de>
|
I think you need to add something like this to the update script |
| tesseract, | ||
| freetype, | ||
| testers, | ||
| audiveris, |
There was a problem hiding this comment.
| audiveris, |
| ''; | ||
|
|
||
| passthru.tests.version = testers.testVersion { | ||
| package = audiveris; |
There was a problem hiding this comment.
| package = audiveris; | |
| package = finalAttrs.finalPackage; |
| ]; | ||
| mainProgram = "audiveris"; | ||
| license = lib.licenses.agpl3Plus; | ||
| maintainers = with lib.maintainers; [ twz123 ]; |
There was a problem hiding this comment.
I'd like to adopt this as well
| maintainers = with lib.maintainers; [ twz123 ]; | |
| maintainers = with lib.maintainers; [ eclairevoyant twz123 ]; |
| for size in 16 24 32 48; do | ||
| # set modify/create for reproducible builds | ||
| gm convert app/res/icon-64.png -scale $size +set date:create +set date:modify icon.png | ||
| install -D -m0644 icon.png "$out/share/icons/hicolor/''${size}x$size/apps/audiveris.png" | ||
| done | ||
| unset size |
There was a problem hiding this comment.
probably overkill, but I won't consider it a blocker either way atm
| }: | ||
| let | ||
| # Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0. | ||
| gradle = gradle_8; |
There was a problem hiding this comment.
We could upgrade to gradle 9 here, as of version 5.7:
https://github.com/Audiveris/audiveris/blob/9b017ff6e16c6da889b4d88718ca0458c9e57d4e/docs/_pages/reference/updates.md?plain=1#L57-L73
Once this package is accepted, I'll work on an update script to make this more automatic.
|
@twz123 Are you still planning to work on this? I plan to open a PR in a week if I haven't heard back. |
Audiveris Music Scanner, an open source Optical Music Recognition (OMR) engine.
This is an alternative to #282848, as I forgot to check open PRs before starting to create a package for myself 🙈. Anyhow, since I just started a fresh package from scratch, this PR uses the new Gradle setup hook. That's why I opted to open another PR.
Closes #282848
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.