Conversation
|
#272380 got merged, so you should adapt this (it should greatly simplify the code). See https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/gradle.section.md |
@chayleaf Full ACK. When I wrote the PR, I think (CC @FliegendeWurst) |
|
Build for platforms other than x64 Linux fails due to #365375. Please mark as broken or fix the fetch invocation (I am not sure how to do that here..) |
Thanks for pointing this out. I wasn't aware of this kind of platform dependency, and it doesn't seem to be mentioned in the Trying your approach from #366098 now. |
|
|
||
| meta = with lib; { |
There was a problem hiding this comment.
| meta = with lib; { | |
| meta = { |
with lib; is outdate
| # we usually don't have access to the commit hashes | ||
| postPatch = '' | ||
| substituteInPlace build.gradle \ | ||
| --replace "git rev-parse --short HEAD" "echo nixos" |
There was a problem hiding this comment.
| --replace "git rev-parse --short HEAD" "echo nixos" | |
| --replace-fail "git rev-parse --short HEAD" "echo nixos" |
--replace outdate
| src = fetchFromGitHub { | ||
| owner = "Audiveris"; | ||
| repo = "audiveris"; | ||
| rev = "${finalAttrs.version}"; |
There was a problem hiding this comment.
| rev = "${finalAttrs.version}"; | |
| tag = "${finalAttrs.version}"; |
for a tag use tag
There was a problem hiding this comment.
"${foo}" is also bad practice when you can just write foo.
|
@zeuner Are you still planning to work on this? I plan to open a PR in a week if I haven't heard back. |
Description of changes
Adding
Audiveris, an open source OMR (optical music recognition) engine capable of generating MusicXML files from scanned music scores: https://audiveris.github.io/audiveris/This is my first attempt on a
gradle-based package, so feel free to suggest improvements. By now, it's already usable, though.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.