Skip to content

buildGoModule: no longer filter out vendorSha256#359798

Merged
Mic92 merged 1 commit intoNixOS:masterfrom
ShamrockLee:build-go-module-vendorsha256-unfilter
Nov 28, 2024
Merged

buildGoModule: no longer filter out vendorSha256#359798
Mic92 merged 1 commit intoNixOS:masterfrom
ShamrockLee:build-go-module-vendorsha256-unfilter

Conversation

@ShamrockLee
Copy link
Contributor

@ShamrockLee ShamrockLee commented Nov 28, 2024

vendorSha256 has gone for good, and those who haven't migrated to vendorHash receive errors.

Let's drop extra handling of vendorSha256 aside from the above-mentioned error guard, and bring us closer to free fixed-point arguments (buildGoModule (finalAttrs: { ... })) support. (Build helper without removeAttrs can be made to support fixed-point arguments using overrideAttrs without having to wait for #234651.)

This is a leftover of #299169.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. label Nov 28, 2024
@Mic92 Mic92 merged commit a4308ab into NixOS:master Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants