buildGoModule: Deprecate vendorSha256 with throw#299169
Merged
wegank merged 1 commit intoNixOS:masterfrom Mar 28, 2024
Merged
Conversation
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
ShamrockLee
force-pushed
the
go-module-vendorsha256
branch
from
7321714 to
49d3b85
Compare
zowoq
reviewed
Mar 26, 2024
ShamrockLee
force-pushed
the
go-module-vendorsha256
branch
4 times, most recently
from
8e860a8 to
a85295e
Compare
zowoq
reviewed
Mar 27, 2024
Ignore vendorSha256 when vendorHash is specified. Throw when vendorHash isn't specified: - "buildGoModule: Expect vendorHash instead of vendorSha256" when vendorSha256 is specified. - "buildGoModule: vendorHash is missing" otherwise. `goModules.outputHashAlgo` is specified as null when vendorHash is not empty, "sha256" otherwise. Co-authored-by: zowoq <59103226+zowoq@users.noreply.github.com>
ShamrockLee
force-pushed
the
go-module-vendorsha256
branch
from
87e95f9 to
c9da94b
Compare
zowoq
approved these changes
Mar 27, 2024
wegank
added
the
12.approvals: 1
SuperSandro2000
approved these changes
Mar 27, 2024
wegank
added
12.approvals: 2
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Ignore vendorSha256 when vendorHash is specified.
Throw when vendorHash isn't specified:
If merged,
vendorSha256is mostly ignored and is no longer an alias tovendorHash, making future development easier.This is a "hard" deprecation of
vendorSha256, following the "soft" deprecation during Nixpkgs 23.11 (#225371). Remaining usage invendorSha256in Nixpkgs has been cleaned up before the release of Nixpkgs 23.11 (#254879, #256514, #256643).Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.