Skip to content

Comments

[Backport release-24.11] chromium: fetch src from git instead of using release tarball, {ungoogled-,}chromium,chromedriver: 130.0.6723.116 -> 131.0.6778.69/85#357678

Merged
emilylange merged 5 commits intorelease-24.11from
backport-357371-to-release-24.11
Nov 21, 2024
Merged

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Nov 20, 2024

Bot-based backport to release-24.11, triggered by a label in #357371.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

emilylange and others added 5 commits November 20, 2024 21:48
This is no longer used as we only differentiate between stable and
ungoogled-chromium, which we already track in the "ungoogled" boolean.

Beta and dev channels are gone for good.
It's been a year since their removal in 59719f7.

There is, however, an additional channel mapping in nixos/tests/chromium
but that one is independent from this one here.

(cherry picked from commit ebb40bd)
This builds upon Yureka's work to build electron from source.
A lot of the newly introduced changes to the chromium derivation and
update script are 1-to-1 copies or slight derivates of that work.

Especially the newly added depot_tools.py to resolve the DEPS files does
most of the heavy lifting and is an ever so slightly modified version of
that section Yureka implemented in electron's update.py.

Some coordination between the chromium and electron maintainers should
allow us to deduplicate a lot of the duplicated code fairly easily in
the future.

That just wasn't a goal with this commit, due to time constraints and
the urgency to switch away from the release tarballs.

Instead of taking just a few hours for a tarball to be available for
download after a release, it now takes multiple days at least.

At the time of writing, roughly a week after M131 was released, the
tarball is still not available. It's unclear if it will ever be.

Reason for this are CI issues on Google's side.

Note that virtually every release contains some security critical fixes.

Also note that this commit is written with a lot of conditionals so the
electron derivation doesn't change (just yet).

The new update.mjs update script is still very much work-in-progress but
gets the job done.

Co-Authored-By: Yureka <yuka@yuka.dev>
(cherry picked from commit 8dd2f1a)
@emilylange
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 357678


x86_64-linux

✅ 38 packages built:
  • aws-azure-login
  • chromedriver
  • chromium
  • chromium.sandbox
  • fast-cli
  • flaresolverr
  • gotenberg
  • grafana-kiosk
  • mermaid-cli
  • mermaid-filter
  • percollate
  • pinnwand
  • pinnwand.dist
  • playwright-test
  • puppeteer-cli
  • python311Packages.great-tables
  • python311Packages.great-tables.dist
  • python311Packages.pytest-playwright
  • python311Packages.pytest-playwright.dist
  • python311Packages.shiny
  • python311Packages.shiny.dist
  • python312Packages.great-tables
  • python312Packages.great-tables.dist
  • python312Packages.pytest-playwright
  • python312Packages.pytest-playwright.dist
  • python312Packages.shiny
  • python312Packages.shiny.dist
  • selendroid
  • selenium-server-standalone
  • sharedown
  • single-file-cli
  • sitespeed-io
  • undetected-chromedriver
  • ungoogled-chromium
  • ungoogled-chromium.sandbox
  • vhs
  • vscode-extensions.yzane.markdown-pdf
  • wayback

@emilylange emilylange merged commit 28626e0 into release-24.11 Nov 21, 2024
@emilylange emilylange deleted the backport-357371-to-release-24.11 branch November 21, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant