chromium: fetch src from git instead of using release tarball, {ungoogled-,}chromium,chromedriver: 130.0.6723.116 -> 131.0.6778.69/85#357371
Merged
emilylange merged 5 commits intoNixOS:masterfrom Nov 20, 2024
Conversation
This is no longer used as we only differentiate between stable and ungoogled-chromium, which we already track in the "ungoogled" boolean. Beta and dev channels are gone for good. It's been a year since their removal in 59719f7. There is, however, an additional channel mapping in nixos/tests/chromium but that one is independent from this one here.
emilylange
added
1.severity: security
This builds upon Yureka's work to build electron from source. A lot of the newly introduced changes to the chromium derivation and update script are 1-to-1 copies or slight derivates of that work. Especially the newly added depot_tools.py to resolve the DEPS files does most of the heavy lifting and is an ever so slightly modified version of that section Yureka implemented in electron's update.py. Some coordination between the chromium and electron maintainers should allow us to deduplicate a lot of the duplicated code fairly easily in the future. That just wasn't a goal with this commit, due to time constraints and the urgency to switch away from the release tarballs. Instead of taking just a few hours for a tarball to be available for download after a release, it now takes multiple days at least. At the time of writing, roughly a week after M131 was released, the tarball is still not available. It's unclear if it will ever be. Reason for this are CI issues on Google's side. Note that virtually every release contains some security critical fixes. Also note that this commit is written with a lot of conditionals so the electron derivation doesn't change (just yet). The new update.mjs update script is still very much work-in-progress but gets the job done. Co-Authored-By: Yureka <yuka@yuka.dev>
https://chromereleases.googleblog.com/2024/11/stable-channel-update-for-desktop_12.html This update includes 12 security fixes. CVEs: CVE-2024-11110 CVE-2024-11111 CVE-2024-11112 CVE-2024-11113 CVE-2024-11114 CVE-2024-11115 CVE-2024-11116 CVE-2024-11117
https://chromereleases.googleblog.com/2024/11/stable-channel-update-for-desktop_12.html This update includes 12 security fixes. CVEs: CVE-2024-11110 CVE-2024-11111 CVE-2024-11112 CVE-2024-11113 CVE-2024-11114 CVE-2024-11115 CVE-2024-11116 CVE-2024-11117
emilylange
force-pushed
the
chromium-src
branch
from
92f60e8 to
54d69a3
Compare
https://chromereleases.googleblog.com/2024/11/stable-channel-update-for-desktop_19.html This update includes 3 security fixes. CVEs: CVE-2024-11395
emilylange
changed the title
Member
Author
|
ofborg
bot
added
11.by: package-maintainer
networkException
approved these changes
Nov 20, 2024
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.05
git worktree add -d .worktree/backport-357371-to-release-24.05 origin/release-24.05
cd .worktree/backport-357371-to-release-24.05
git switch --create backport-357371-to-release-24.05
git cherry-pick -x ebb40bd5c29f08765e6ed94d00a889e09a9e30de 8dd2f1add978a4747a5962f2874b8ad20f86b01c 875ae81fe547a7296f8386f977852d04186e975d 54d69a3c7942dac4a7b41725b9f71b1ab143dc9c eaa1bb9980eb6444076fce1470c568001c3b4f1f |
Contributor
|
Successfully created backport PR for |
1 task
13 tasks
13 tasks
Member
Author
Manual backport in #357925 |
This was referenced Dec 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please refer to the commit message for details.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)